J4 Issue ?
Related to # 15956
avatar wilsonge
wilsonge
3 Jul 2017

Follow up out of #15956

This is more complicated than it seems because we probably need to offer a tool to our users to upgrade existing articles (we shouldn't try and modify articles ourselves on upgrade as it's a recipe for a disaster)

avatar wilsonge wilsonge - open - 3 Jul 2017
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jul 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 3 Jul 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Jul 2017
Category JavaScript
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Jul 2017
Rel_Number 0 15956
Relation Type Related to
avatar brianteeman
brianteeman - comment - 12 Jul 2017

we shouldn't try and modify articles ourselves

We should never touch a users data

avatar franz-wohlkoenig franz-wohlkoenig - change - 25 Jul 2017
Status New Discussion
avatar brianteeman brianteeman - change - 25 Mar 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar laoneo
laoneo - comment - 18 May 2018

Can we close this one in favor of #20153?

avatar brianteeman
brianteeman - comment - 18 May 2018

although I agree that html5 is the better way because of the difficulties with upgrades then yes it should be closed. My 2c only

avatar Bakual
Bakual - comment - 18 May 2018

First we need to look at what will happen if we remove the caption.js:
All articles created since Joomla 3.2.2 (released 2104-02-06) already use the figure element when the caption was created using the editor button. For those there will be no change in behavior.
Articles created before that time (over 4 years old!) will loose the caption. The text will instead still be in the regular title attribute and the browser will show it when hovering over the picture. So it's not lost, but it appears different.

Imho, that is a minor thing which doesn't need solving. But if it is important for a site that the captions appear, they can still include the existing caption.js into their template or use a plugin which does something similar.

From my pov this can be closed.

avatar laoneo
laoneo - comment - 18 May 2018

Ok. Going to close this one and merge the caption.js removal. I'v also added the documentation required label on the pr that we do not forget to document that break.

avatar laoneo laoneo - change - 18 May 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-05-18 11:02:38
Closed_By laoneo
avatar laoneo laoneo - close - 18 May 2018

Add a Comment

Login with GitHub to post a comment