[#16949] - [com_fields] Show the loading icon only when needed
- Fixed in Code Base
- 6 Jul 2017
- Medium
- Build: staging
- # 16949
- Diff
- Digital-Peak:cf/load-js
User tests: Successful: Unsuccessful:
When a category is changed on article edit, then a JS event is triggered to show the loading icon till the page reload is done. When the event is triggered by an external script and the catid field hasn't changed it returns without shutting down the loading icon properly.
This pr changes the behavior to show the loading icon, only when needed.
Actually I can't offer test instructions as this is happening with one of my commercial extensions. But it should be good to merge as all it does is moving a line after a return statement. Pinging here @rdeutz as release lead as it should fine to merge by review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Title |
|
||||||
I have tested this item
Done Code Review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16949.
I have tested this item
On code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16949.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Looks good to me
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-06 07:32:55 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Thanks @dgt41 for the review!