Feeling Lucky
?
?
[#16947] - [CODE STYLING] Fixes code styling in cms-uncompressed.js
- Fixed in Code Base
- 6 Jul 2017
- Medium
- Build: staging
- # 16947
- Diff
- regularlabs:patch-2
User tests: Successful: Unsuccessful:
Fixes code styling in cms-uncompressed.js
- indentation
- use of braces
- whitespace
- etc
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Status | Pending | ⇒ | Ready to Commit |
laoneo
- comment
- 3 Jul 2017
Are the comments of the Hound CI valid ones or will they be ignored?
wilsonge
- comment
- 3 Jul 2017
None of the issues are introduced with this PR. They're all existing so for the purposes of this PR it's all good. In the long run it should be cleaned up though
regularlabs
- comment
- 3 Jul 2017
I'll do a cleanup of some of these (dot notation, confusing '!') after this PR is merged.
C-Lodder
- comment
- 3 Jul 2017
Sure will do
rdeutz
- comment
- 6 Jul 2017
This needs a test
regularlabs
- comment
- 6 Jul 2017
Code styling fixes don't need tests.
Especially not when the final minified js file (the one that gets loaded) is not affected.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-06 10:46:33 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
|
||
rdeutz
- comment
- 6 Jul 2017
So it is only cosmetic ;-) Merged
RTC on review for 3.7.4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16947.