Do we still need the caption.js? Imho all it does is what native HTML already can do for quite some time.

Would be nice to get rid of it.

as far as I remember, we kept it for B/C some time in the past.

There are 2 options here

• create one more layout override in the front end template e.g. legacy.php
• update all content to use figure (tinyMCE does that already, but probably needs an sql script for content table)

update all content to use figure (tinyMCE does that already, but probably needs an sql script for content table)

I would be very reluctant to do anything that alters a users data

@brianteeman so we need one legacy.php override.
Anyways this PR mainly created as a guideline to the javascript tests for the GSOC student (no inline scripts and a way to cope with Joomla.storageOptions)

as far as I remember, we kept it for B/C some time in the past.

We kept it for B/C when we changed the image button to use the native elements. But with J4 we can imho drop it. Maybe make it available as extern plugin for those who still need it for some reason.

create one more layout override in the front end template e.g. legacy.php

What for? What would that override achieve?

update all content to use figure (tinyMCE does that already, but probably needs an sql script for content table)

Nah, never change user data. You can document it for users who want to do that themself or offer the JS as a plugin as I said above. But we need to drop that JS anyway and it will have the same impact if we do that in J4 or Jx.

@Bakual https://github.com/joomla/joomla-cms/pull/15956/files#diff-f6f264d0b0673dc25ecc75e7746ec235R77
it not even marked as deprecated ATM, so dropping it at least requires some prior notification...
Anyways I'm not against removing this legacy thing, just don't want to be the person to blame once again ?

just don't want to be the person to blame once again ?

You're the George of our JavaScript code, everything's your fault ?

I know ?

it not even marked as deprecated ATM

We can easily deprecate it in 3.8.

I have tested this item ✅ successfully on 73222e9

code review

@dgt41 can you take a look into the conflict?

@zero-24 done!

OK I'm going to merge this. But I've also created a follow up issue #16948 for dropping caption altogether as it's a non-trivial migration path so isn't 'straightforward'