Success

User tests: Successful: Unsuccessful:

avatar elkuku
elkuku
14 Aug 2015

This will add an onTestAfterSubmit event and a JoomlacmsTestsListener event listener that will create a status on GitHub whenever a test is submitted (or altered) on jissues.

FYI GitHub statuses are those annoying messages that appear for "external services" like Travis.

In our case this would reflect the test results (from JBS) to the GitHub UI along with the Travis (or other) test results.

Example:

usr-tests

The text that appears is fully customizable for every project and I would beg you to postpone discussions about the wording after and only if this PR has been merged - thanks ?

Depends on #694, closes #596

avatar elkuku elkuku - open - 14 Aug 2015
avatar b2z
b2z - comment - 29 Aug 2015

#694 is merged now and we can start to test listeners.

And now here is the problem:

PHP Fatal error:  Call to undefined method
App\\Tracker\\Controller\\TestResult\\Ajax\\Submit::addEventListener()
in
JROOT/src/App/Tracker/Controller/TestResult/Ajax/Submit.php on line 54

AbstractAjaxController extends AbstractTrackerController that is not aware about hooks. Funny thing is that our AbstractHookController extends AbstractAjaxController :smile: We need to sort out our hierarchy here :wink:

avatar elkuku
elkuku - comment - 29 Aug 2015

This looks like changes from the master branch are missing - updated :wink:

The hooks controllers are extending the base AJAX controller because of the response being in JSON notation... I also scratched my head about this after not seeing the code for a while...

avatar mbabker
mbabker - comment - 29 Aug 2015

I changed that a while back so that when you're looking at the events in GitHub's admin console the response in there isn't a full HTML page (digging through a couple hundred lines of that to find error messages is a pain).

avatar elkuku
elkuku - comment - 29 Aug 2015

Ah, that makes sense.
TBH I wasn't even aware that GitHub stores all those responses and corresponding payloads... pretty awesome! - thanks again @github :wink:

avatar elkuku
elkuku - comment - 30 Aug 2015

A diagram of some of our controller classes:
diagram

avatar b2z
b2z - comment - 3 Sep 2015

Works good now! The only problem is the link Details from Github to Tracker. When I click on it I get an error:

404 UnexpectedValueException
This project does not exist.

Testing here
b2z/jissues-test#15

avatar mbabker
mbabker - comment - 3 Sep 2015

The link is hardcoded to issues.joomla.org and that project doesn't exist on our live site :wink:

avatar b2z
b2z - comment - 3 Sep 2015

Oh my :) Did notice that it leads to i.j.o :) Well I think this PR is ready for merge.

avatar b2z b2z - change - 3 Sep 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-09-03 18:18:34
Closed_By b2z
avatar b2z b2z - close - 3 Sep 2015
avatar b2z b2z - reference | 068bcd7 - 3 Sep 15
avatar b2z b2z - merge - 3 Sep 2015
avatar b2z b2z - close - 3 Sep 2015
avatar elkuku elkuku - head_ref_deleted - 3 Sep 2015

Add a Comment

Login with GitHub to post a comment