User tests: Successful: Unsuccessful:
This will add an onTestAfterSubmit
event and a JoomlacmsTestsListener
event listener that will create a status on GitHub whenever a test is submitted (or altered) on jissues.
FYI GitHub statuses are those annoying messages that appear for "external services" like Travis.
In our case this would reflect the test results (from JBS) to the GitHub UI along with the Travis (or other) test results.
Example:
The text that appears is fully customizable for every project and I would beg you to postpone discussions about the wording after and only if this PR has been merged - thanks
This looks like changes from the master
branch are missing - updated
The hooks controllers are extending the base AJAX controller because of the response being in JSON notation... I also scratched my head about this after not seeing the code for a while...
I changed that a while back so that when you're looking at the events in GitHub's admin console the response in there isn't a full HTML page (digging through a couple hundred lines of that to find error messages is a pain).
Works good now! The only problem is the link Details
from Github to Tracker. When I click on it I get an error:
404 UnexpectedValueException
This project does not exist.
Testing here
b2z/jissues-test#15
The link is hardcoded to issues.joomla.org
and that project doesn't exist on our live site
Oh my :) Did notice that it leads to i.j.o :) Well I think this PR is ready for merge.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-09-03 18:18:34 |
Closed_By | ⇒ | b2z |
#694 is merged now and we can start to test listeners.
And now here is the problem:
AbstractAjaxController
extendsAbstractTrackerController
that is not aware about hooks. Funny thing is that ourAbstractHookController extends AbstractAjaxController