Success

User tests: Successful: Unsuccessful:

avatar elkuku
elkuku
13 Aug 2015

This moves the event handling methods from the hooks controller to the base controller to make them available to all controllers.

Adds a new event onTestAfterSubmit - listeners will follow are here: #695, #696 ?

Currently open #596 could be implemented using events.
I believe that also the code from #667 could be done using an appropriate event instead of commenting ?

avatar elkuku elkuku - open - 13 Aug 2015
avatar b2z
b2z - comment - 16 Aug 2015

Now testing this branch here. #667 is broken :(

avatar elkuku
elkuku - comment - 17 Aug 2015

Do you get some kind of error or does is just not work?

avatar b2z
b2z - comment - 17 Aug 2015

Nothing. It is just not triggered. I will try to test on master branch later today to see is it something wrong on my server or not.

avatar elkuku
elkuku - comment - 17 Aug 2015

Hmm thinking about it I guess this is caused by the way we get the project "object" inside the hooks controllers...
I wasn't expecting anybody testing hooks with a "non joomla-cms project"...

Let me think a bit about some adjustments...

avatar elkuku
elkuku - comment - 17 Aug 2015

OK I made some further adjustments. Could you re-sync please?

Since this resolves a @todo added by @mbabker, may I request a small code review on ab37def please?

avatar elkuku
elkuku - comment - 17 Aug 2015

May I SPAM>>> something (almost) completely unrelated here? Postman is pretty cool for crafting POST requests - to debug webhooks for example.
It looks like this:

2015 08 17 120721_1366x768_scrot

<<<SPAM

avatar b2z
b2z - comment - 17 Aug 2015

Resynced and it works now :) :+1:

avatar elkuku
elkuku - comment - 17 Aug 2015

Fantastic :tada:

avatar b2z
b2z - comment - 17 Aug 2015

And what's the possible problem in code with ab37def ?

avatar elkuku
elkuku - comment - 17 Aug 2015

The sky may fall down on us :tongue:

No well, since it was a @todo, I would like to ensure that it has been properly done :wink:

avatar mbabker
mbabker - comment - 17 Aug 2015

At a glance it seems fine.

avatar b2z b2z - change - 29 Aug 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-08-29 03:41:22
Closed_By b2z
avatar b2z b2z - close - 29 Aug 2015
avatar b2z b2z - reference | 4d4f818 - 29 Aug 15
avatar b2z b2z - merge - 29 Aug 2015
avatar b2z b2z - close - 29 Aug 2015
avatar elkuku elkuku - head_ref_deleted - 29 Aug 2015

Add a Comment

Login with GitHub to post a comment