[#696] - JoomlacmsItemsListener
- Closed
- 29 Mar 2017
- Medium
- Build: master
- # 696
- Diff
- joomla:item-events
- Success continuous-integration/travis-ci/push The Travis CI build passed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
As discussed here: #692 (comment)
This will add
- an
onItemAfterSaveand anonItemAfterSubmitevent - a
JoomlacmsItemsListenerevent listener
Note that this will modify the feature added in #667.
It should be possible now to have changes to an item reflected to GitHub without the need for a comment
To test
- change the status for an issue to 'RTC' while editing on jissues
- check that the 'RTC' label is added to the issue on GitHub.
Obviously JBS testing depends on previous merging and deploying...
Depends on #694.
| Title |
|
||||||
Can we use a Trait for setProjectGitHubBot ?
Maybe, I'm not sure..
What if we add a new method to the GitHubFactory class that returns a project bot or an error?
I believe there are several instances in the current code that could use this functionality.
Should we use a GitHubAwareTrait that might go into the base controller?
Could we implement this in another PR?..
Ok I've switched my test server to this PR.
Ok for the jissues-test repo i have access. But on saving a item i get a blank page?
Do you expect to rename the listener? (JoomlacmsCommentsListener.php → JoomlacmsItemsListener.php)
But not: the: ReceiveCommentsHook? (https://github.com/joomla/jissues/blob/item-events/src/App/Tracker/Controller/Hooks/ReceiveCommentsHook.php)
Ok for the jissues-test repo i have access. But on saving a item i get a blank page?
An error is for Save controller which calls undefined method addEventListener:
$this->addEventListener('items');
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-29 17:32:55 |
| Closed_By | ⇒ | elkuku |
Can we use a Trait for
setProjectGitHubBot?