[#7031] - #6967 Compact list of tagged items. New option Items to List
- Closed
- 20 Oct 2015
- Medium
- Build: staging
- Easy Test
- # 7031
- Diff
- bertmert:patch-20
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
See feature request #6987
Menu item type Compact list of tagged items.
This PR adds a new option # Items to List like in menu item type Articles > Category List.
It removes old option Item Selection Options > Maximum Items because not needed anymore.
Test instructions:
- Create a tag.
- Apply it to several items (20, 30 ...) like articles, categories, contacts... It's easy with button Batch.
- Create a menu item of type Compact list of tagged items and select above tag.
- Save & Close.
- Open in frontend but do not touch limit box yet!!!
Number of diplayed items = Default List Limit in Global Configuration of Joomla.
(If not delete cookie [= kill session], clear browser cache and reload page).
Apply patch.
- Reload page in frontend. Nothing changed. Do not touch limit box yet!!!
- Backend > open menu item.
Change new option List Layouts > # Items to List. E.g. to 5
Reload page in frontend.
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Category | ⇒ | Front End |
| Status | New | ⇒ | Pending |
| Easy | No | ⇒ | Yes |
Yes, I know. I wondered too. I don't know why. I tried to make this "strange connection" a bit more transparent for users by text.
I had to search inside PHP code to find this solution for limiting items (before PR)
#6987 (comment)
Just doesnt seem right to me and its not consistent
On 26 May 2015 12:53, "bertmert" notifications@github.com wrote:
Yes, I know. I wondered too. I don't know why. I tried to make this
"strange connection" a bit more transparent for users by text.I had to search inside PHP code to find this solution for limiting items
(before PR)
#6987 (comment)
#6987 (comment)—
Reply to this email directly or view it on GitHub
#7031 (comment).
The old behaviour doesn't seem right to you? Or the new one combined with old one?
The requirement to display the list box.
I share the same opinion right from the start. I will work over the PR, remove old maximum field that we don't need any more. I close PR just for a short time to avoid tests.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-26 13:59:45 |
| Closed_By | ⇒ | bertmert |
It should work the same as category list
On 26 May 2015 14:59, "bertmert" notifications@github.com wrote:
—
Reply to this email directly or view it on GitHub
#7031 (comment).
| Status | Closed | ⇒ | New |
| Closed_Date | 2015-05-26 13:59:45 | ⇒ | |
| Closed_By | bertmert | ⇒ |
Removed old field|option maximum|Maximum Items and dependency on field Display Select.
If this PR works error free same feature, same changes should be applied to menu item type Tags » Tagged Items (with another PR please).
| Status | New | ⇒ | Pending |
| Title |
|
||||||
This patch works.But i'm bit confused because without the patch too it's working here.Only difference is once i added the patch i can manually set the starting value for the dropdown.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7031.
@BuddhiEash Read the discussion here and my linked comment in related issue and you'll see the difference.
bertmert : Got that point 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7031.
| Status | Pending | ⇒ | Ready to Commit |
Thanks for coding and testing 
Moving to RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7031.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Labels |
Added:
?
?
|
||
wilsonge
- | Milestone |
Added: |
||
Merge conflicts ;)
And again I've forgotten how to solve it.
(I'm only working with github com GUI)
You cant solve merge conflicts with GUI ;(
the fasted solution (with the GUI) is close here and open a new PR (with the same changes) based on the current code base.
via cli:
git checkout patch-20
git pull upstream staging
<git tell you here which files has conflicts so they need to be fixed local)
git commit -am 'fix merge conflicts'
git push origin patch-20
Thank u for informations @brianteeman and @zero-24
will open new one
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-20 12:45:48 |
| Closed_By | ⇒ | bertmert |
| Milestone |
Removed: |
||
| Labels |
Removed:
?
|
||
Issue confirmed
PR Resolves it BUT
Why is it linked to displaying the limit box?
"Default number of tagged items to list on a page. Only if limit box is shown (Display Select: Show).
If you look at category list menu item for example there is not connection to displaying the limit box
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7031.