[#8116] - Compact list of tagged items. New option Items to List
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is a 1:1 copy of PR #7031 because of a merge conflict there.
See discussion and test results there please.
Copied instructions;
See feature request #6987
Menu item type Compact list of tagged items.
This PR adds a new option # Items to List like in menu item type Articles > Category List.
It removes old option Item Selection Options > Maximum Items because not needed anymore.
Test instructions:
- Create a tag.
- Apply it to several items (20, 30 ...) like articles, categories, contacts... It's easy with button Batch.
- Create a menu item of type Compact list of tagged items and select above tag.
- Save & Close.
- Open in frontend but do not touch limit box yet!!!
- Number of diplayed items = Default List Limit in Global Configuration of Joomla.
(If not delete cookie [= kill session], clear browser cache and reload page).
- Apply patch.
- Reload page in frontend. Nothing changed. Do not touch limit box yet!!!
- Backend > open menu item.
- Change new option List Layouts > # Items to List. E.g. to 5
- Reload page in frontend.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Title |
|
||||||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Rel_Number | 0 | ⇒ | 7031 |
| Relation Type | ⇒ | Pull Request for | |
| Labels | |||
| Category | ⇒ | Front End |
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-25 17:09:21 |
| Closed_By | ⇒ | roland-d |
wilsonge
- | Labels |
Removed:
?
|
||
It's clearly not merged because it's still not in the current version of Joomla lol
Then it got lost with 3.5-dev for what ever reason anyway can you redo the pr for 4.0?
It's clearly not merged because it's still not in the current version of Joomla lol
Well the code is in 3.9.22:
https://github.com/joomla/joomla-cms/blob/3.9.22/components/com_tags/views/tag/tmpl/list.xml#L202
https://github.com/joomla/joomla-cms/blob/3.9.22/components/com_tags/models/tag.php#L221
(I have not tested whether that feature still works but atleast the code was not removed but correctly added and is still shipped with 3.9.x)
Oh I see. So there is a lot of confusion with this I guess.
It looks like this is only available in the "Compact" layout and not in "Normal" layout.
Also, it appears this is only available in the Menu Item settings but it's not in Global Configuration at all.
Weird.
It may as nothing was changed versus 3.x in the sense that the default number of tagged items for the Tagged Items menu item does not include a field to define a default list limit.
It could be added in another PR.
It may as nothing was changed versus 3.x in the sense that the default number of tagged items for the
Tagged Itemsmenu item does not include a field to define a default list limit.
It could be added in another PR.
Could definitely be good if you could make a PR for it. It should also be ported into Global Configuration, as it's missing from there.
PS: This setting ties in with the idea that Tag views should offer similar features (and appearance) to Category views in my opinion: #30998 (comment)
articles category views are very different from tags as they concern the same type of items.
Thanks RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8116.