? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
25 May 2015

Since #5140 we had to correct many aspects of the languagefilter plugin because of the confusion introduced by the variable $default_lang which was not anymore representing the default site language tag but the current page language tag.

This PR re-introduces a true $default_lang which will replace in the plugin all occurences of
JComponentHelper::getParams('com_languages')->get('site', 'en-GB')
and change the existing one to $current_lang.

Please test all aspects of multilanguage.

A simple test for the validity of $current_lang is to define a custom site name for content languages and look at the site name displayed in the browser tab.

avatar infograf768 infograf768 - open - 25 May 2015
0f9693e 25 May 2015 avatar infograf768 cs
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 25 May 2015
Status New Pending
Easy No Yes
avatar zero-24 zero-24 - change - 25 May 2015
Category Multilanguage Plugins
1bc9dca 25 May 2015 avatar infograf768 cs
avatar infograf768 infograf768 - change - 25 May 2015
The description was changed
avatar Gitjk
Gitjk - comment - 27 May 2015

Tested with latest staging and latest bilingual VirtueMart shop. Didn't see any language problem. The 'simple test' with custom site names as described above, did work as expected, too.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7032.

avatar Gitjk Gitjk - test_item - 27 May 2015 - Tested successfully
avatar smz
smz - comment - 27 May 2015

@test OK, everything as expected!

... and it is really good to have that variable's name fixed!

Thanks!

avatar infograf768 infograf768 - change - 27 May 2015
Status Pending Ready to Commit
avatar smz smz - test_item - 27 May 2015 - Tested successfully
avatar Bakual Bakual - change - 28 May 2015
Labels Added: ?
avatar Bakual
Bakual - comment - 28 May 2015

Merged into staging. Thanks!

avatar Bakual Bakual - change - 28 May 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-05-28 06:16:55
Closed_By Bakual
avatar Bakual Bakual - close - 28 May 2015
avatar zero-24 zero-24 - close - 28 May 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment