Feeling Lucky
?
[#7030] - Declare visibility for method _getUserDisplayedGroups
- Closed
- 25 May 2015
- Medium
- Build: staging
- # 7030
- Diff
- photodude:patch-5
- Error The Travis CI build could not complete due to an error Details
User tests: Successful: Unsuccessful:
Best Practices fix: It is generally recommended to explicitly declare the visibility for methods.
Assuming public for method _getUserDisplayedGroups
joomla-cms-bot
- | Labels |
Added:
?
|
||
wilsonge
- comment
- 25 May 2015
Just leave it for 4.x - there's a handful of places with the same kind of thing which we should just change en-masse. I'll merge this "as is" - thankyou!
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-25 01:12:31 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
This should be protected (the reason I know is because the method starts with an _ which used to indicate it was protected/private before the days of modern code in the CMS)