[#6106] - Add missing semi-colons
- Closed
- 24 Mar 2015
- Medium
- Build: staging
- # 6106
- Diff
- wilsonge:semicolons
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This adds some semi colons missing from the file. Note that this has been applied automatically to the compressed file so there are no issues there
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Code style JavaScript |
| Milestone |
Added: |
||
lol, how in the world did this pass travis?
Bear
On 3/9/2015 03:44, Peter van Westen wrote:
Maybe also add the missing semi-colons to lines 151, 230 & 231
—
Reply to this email directly or view it on GitHub
#6106 (comment).No virus found in this message.
Checked by AVG - www.avg.com http://www.avg.com
Version: 2015.0.5751 / Virus Database: 4299/9261 - Release Date: 03/09/15
Travis only tests the things we have unit tests for. Which is less than 50% of our php code in the libraries folder. Nothing else is covered by travis
Hi George, please fix line 230 & 231 too.
@nueckman Line 231, 232 ?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6106.
231, 232: Add semi-colon to end.
My bad - done
@test success
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6106.
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-24 09:35:34 |
Maybe also add the missing semi-colons to lines 151, 230 & 231