[#6107] - Discover function in module & template adapters missing a file exists check
- Closed
- 15 Mar 2015
- Medium
- Build: staging
- # 6107
- Diff
- mbabker:discoverTemplates
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
When discovering new extensions, the module & template adapters fail to check for the presence of an extension manifest XML file which means that extension folders which aren't properly set up are listed as installable. This PR adds a file_exists() check which should block these uninstallable folders from being discovered as installable.
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Libraries |
In this case, no. When you're discovering extensions, the system is scanning for valid extensions that have not been installed. Missing a manifest means the extension isn't valid so it should never get registered. None of the other adapters raise errors in this scenario either.
Looks good.
Looks good, should be RTC.
brianteeman
- | Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-15 09:19:06 |
Merged. Thanks!
Do we need a new error if file does not exist?