although I'd suggest

this has a performance penalty for logged in users rather than the significant performance penalty

There you go

significant has a typo

fixed.

@wilsonge Eagle eyes! :-)

@Hackwar Good improvement, thank you!

I thought we were in language freeze - another PR that changes a single character has already been rejected :(

and brian if you notice i set the milestone to 3.4.1 ;)

Brian, I'm arguing with Thomas about this feature in #6041 and the argument right now is, that the switch is so hard to find, that we can't expect people to switch this on again if we were to switch it off and thus we can't change that setting. So since nobody seems to want to change this language string, I went ahead and created a PR. I'm very happy if someone else would propose something better, since, while I call my English good, I'm very far from perfect. But I also don't want to let anybody say "hey, its difficult to find, nobody is doing something against that, so we can't change this."

RTC

George the english is terrible and makes no sense surely even you can see that

Maybe I shouldn't be doing this at this time of night.....

Can you please do a replacement PR or PR into Hannes branch please. Because Hannes is right as well that what's there equally makes no sense

But is it even correct to say it has a significant performance hit. There is an effect but isnt that a bit strong?

Well this was the cause of that 33% hit we saw in 3.4. We only fixed it for users not logged in. I dunno how hard we wanna be with the wording but we probably should let the users know there is a penalty for using it.

I'm agreeing with the need for a message but if we make it that hard no one
will ever use it and yet we are stating it is a key feature of the release.
I would prefer a softer notice and then make it a code priority to look at
resolving the performance issue. Otherwise we should drop the feature
completely
On 3 Mar 2015 00:43, "George Wilson" notifications@github.com wrote:

Well this was the cause of that 33% hit we saw in 3.4. We only fixed it
for users not logged in. I dunno how hard we wanna be with the wording but
we probably should let the users know there is a penalty for using it.

—
Reply to this email directly or view it on GitHub
#6105 (comment).

Setting to needs review until someone give the advice to use this text or another. Thanks.