? Success
Referenced as Related to: # 4912 # 4939

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
24 Oct 2014

PR summary

This PR fix the issue #4912 reported by @brianteeman. Basically, when you open an article, change it's title (and maybe alias), then press "Save as Copy" button, the system should create a new article with the new title (and alias) which you entered.

However, at the moment, Joomla simply ignore the change you made before pressing "Save as Copy", it simply append (2) to the title (and alias) of the original article and use it as Title (and alias) of the new article. This is unexpected behavior and this PR fix it.

How to test

  1. Open an existing article
  2. Change it's title (and maybe alias)
  3. Press "Save as Copy" button. Make sure the system generate new article with the entered title (and alias), instead of appending (2) to the title of the article and use it as title of the new article.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar joomdonation joomdonation - open - 24 Oct 2014
avatar jissues-bot jissues-bot - change - 24 Oct 2014
Labels Added: ?
avatar joomdonation
joomdonation - comment - 24 Oct 2014

Forgot to mention this PR also fix some code styles as well.

avatar brianteeman brianteeman - change - 24 Oct 2014
Category Components UI/UX
avatar brianteeman
brianteeman - comment - 24 Oct 2014

Tested and worked perfectly
Repeating the instructions I gave in the original report and I know get the expected results

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4916.

avatar brianteeman brianteeman - test_item - 24 Oct 2014 - Tested successfully
avatar joomdonation
joomdonation - comment - 24 Oct 2014

Thanks @brianteeman. One more tester and we can get it merged.

avatar brianteeman brianteeman - change - 24 Oct 2014
Easy No Yes
avatar infograf768
infograf768 - comment - 26 Oct 2014

@test
This works fine here too. Merging.
Would be good to make it consistent over the core.

avatar infograf768 infograf768 - close - 26 Oct 2014
avatar infograf768 infograf768 - change - 26 Oct 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-10-26 10:00:56
avatar joomdonation
joomdonation - comment - 26 Oct 2014

Thanks JM. As mentioned, I see this issue happens on Contacts and Weblinks as well, so I will create a PR to fix in these components as well. Thanks again :).

avatar infograf768
infograf768 - comment - 27 Oct 2014

Same issue for Categories and Banners
For Newsfeeds it is slightly different in the sense that the new title is OK but the alias gets -2 appended.
Therefore the 3 are concerned.

For weblinks I guess the PR should be proposed int the specific weblinks project

avatar infograf768
infograf768 - comment - 27 Oct 2014

@joomdonation
If you wish, I already prepared a patch based on your code, except for weblinks.

avatar joomdonation
joomdonation - comment - 27 Oct 2014

Thanks JM. Could you please open PRs with your code ? We will just need to test it and get it merged :)

avatar infograf768
infograf768 - comment - 27 Oct 2014

Please test
#4939

Add a Comment

Login with GitHub to post a comment