? Success
Referenced as Related to: # 4907

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
24 Oct 2014

PR summary

This PR fixes the issue #4907 reported by @brianteeman. Please see #4907 for details description of the issue, he explained it very well.

How to test:

  1. Make sure your site has more than one language available.

  2. Apply this PR

  3. Login to back-end of your website, then go to Users -> Users Manager, click on an existing users to edit. Look at Basic Settings tab, there are two params "Backend language" and "Frontend language", please check and make sure the languages displayed in these languages dropdown are sorted by locale.

avatar joomdonation joomdonation - open - 24 Oct 2014
avatar jissues-bot jissues-bot - change - 24 Oct 2014
Labels Added: ?
avatar infograf768
infograf768 - comment - 26 Oct 2014

How to really test?
Here, before and after, the languages order is alpha based on the tags which are ascii.
Below: de-DE, en-GB, es-ES, etc.
screen shot 2014-10-26 at 10 05 14

avatar joomdonation
joomdonation - comment - 26 Oct 2014

@infograf768

This issue is the same with #4679 which was fixed with the PR #4690 . This issue rarely happens (seems it only happens with some special conditions), so it is difficult for us to replicate it.

So if we really want to test it, just make sure the languages are sorted in locale (expected behavior) and it should be OK.

We also need @brianteeman to confirm that this PR fixed the issue on the site he is seeing the issue as well before merging it.

avatar infograf768
infograf768 - comment - 26 Oct 2014

For me, no change before or after, so we can merge if solved on the said site indeed.

avatar joomdonation
joomdonation - comment - 26 Oct 2014

Yes, there is no change for me as well (the same as in PR #4690). But It can happen (atleast @brianteeman and @dkanchev saw it).

So if @brianteeman confirms that this PR fixes the issue he is seeing on that site, we can merge it.

While you are here, could you help looking at #4916 as well ? It would be nice to have the issue mentioned on that PR fixed.

avatar brianteeman
brianteeman - comment - 26 Oct 2014

I am trying to get Daniel to confirm

On 26 October 2014 09:54, Tuan Pham Ngoc notifications@github.com wrote:

Yes, there is no change for me as well (the same as in PR #4690
#4690). But It can happen
(atleast @brianteeman https://github.com/brianteeman and @dkanchev
https://github.com/dkanchev saw it).

So if @brianteeman https://github.com/brianteeman confirms that this PR
fixes the issue he is seeing on that site, we can merge it.

While you are here, could you help looking at #4916
#4916 as well ? It would be
nice to have the issue mentioned on that PR fixed.


Reply to this email directly or view it on GitHub
#4917 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar joomdonation
joomdonation - comment - 26 Oct 2014

That would be great. Thanks Brian

avatar dkanchev
dkanchev - comment - 27 Oct 2014

Hi guys, sorry for the late reply! I tested the proposed patch - it works as expected :) 10x for the solution!

avatar infograf768 infograf768 - close - 27 Oct 2014
avatar infograf768 infograf768 - change - 27 Oct 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-10-27 07:43:22
avatar infograf768
infograf768 - comment - 27 Oct 2014

Thanks.

avatar joomdonation
joomdonation - comment - 27 Oct 2014

Thanks All :)

Add a Comment

Login with GitHub to post a comment