? Success
Related to # 4916

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
27 Oct 2014

Same fixes as in #4916 for these components.
For any of these items:
Change the Title/name
Press Save as Copy.
Instead of a figure, the new item will get the new title/name and new alias based on the title/name

Thanks original code is by @joomdonation

avatar infograf768 infograf768 - open - 27 Oct 2014
avatar jissues-bot jissues-bot - change - 27 Oct 2014
Labels Added: ?
avatar infograf768
infograf768 - comment - 27 Oct 2014

Same issue for weblinks: needs a separate PR in the weblinks project.
I did not do menu items in this patch as it looks we may have to check for other aspects in the code.

avatar joomdonation
joomdonation - comment - 27 Oct 2014

Thanks JM. Could you please change the the line of code from:

 $origTable->load((int) $input->getInt('id'));

To:

$origTable->load($input->getInt('id'));

We call $input->getInt('id'), so the data is sanitized to integer already and no need for (int) before.

Please help making the change in the article model as well.

From my quick review, It looks OK. I will test it with the mentioned components when I get home later today.

929acc8 27 Oct 2014 avatar infograf768 cs
avatar infograf768
infograf768 - comment - 27 Oct 2014

Done as well as ither code style issues.
Corrected article directly with another cs too

avatar joomdonation
joomdonation - comment - 27 Oct 2014

@test: Works as expected for banners, categories,contacts, newsfeeds.

avatar brianteeman brianteeman - change - 27 Oct 2014
Rel_Number 4916
Relation Type Related to
avatar anibalsanchez
anibalsanchez - comment - 27 Oct 2014

@test OK

  1. Open a banner, Save as copy 1.1. Open a banner category, Save as copy, and published 1.2. Assigned the new category and published
  2. Open a category, Save as copy, published
  3. Open a contact, Save as copy 3.1 Open a contact category, Save as copy, and published 3.2. Assigned the new category and published
  4. Open a newsfeed, Save as copy 4.1 Open a newsfeed category, Save as copy, and published 4.2. Assigned the new category and published
avatar infograf768 infograf768 - close - 28 Oct 2014
avatar infograf768 infograf768 - change - 28 Oct 2014
Title
[Fix] Save as copy for banners, categories,contacts, newsfeeds
[imp] Save as copy for banners, categories,contacts, newsfeeds
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-10-28 07:06:22

Add a Comment

Login with GitHub to post a comment