?
Related to # 4916
avatar brianteeman
brianteeman
24 Oct 2014

Steps to reproduce the issue

  1. Create an article called test and save it
  2. Reopen that article, rename it Fred and save as copy
  3. Rename it Mary and save and close

Expected result

Three published articles with title/alias
Article/article
Fred/fred
Mary/mary

Actual result

Article/article - Published
Fred (2)/article-2 - Unpublished
Mary (2)/article-3 - Unpublished

The article title should not have the (2) (that should only happen on copy from the article manager when you do not change the title) and the alias should be generated on the new title not the old one.

Additional Comments

Whether the new article should be published or unpublished is a different decision and one I am not that concerned about.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
2.00

avatar brianteeman brianteeman - open - 24 Oct 2014
avatar brianteeman
brianteeman - comment - 24 Oct 2014

Note that when you use the batch facility to copy an article the default state of the copied article is published

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4912.

avatar infograf768
infograf768 - comment - 24 Oct 2014

It should not

avatar infograf768
infograf768 - comment - 24 Oct 2014

and does not here

avatar brianteeman
brianteeman - comment - 24 Oct 2014

Please see this video recording I just made with Joomla 3.3.6
http://youtu.be/QAJUt7TglVE

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4912.

avatar infograf768
infograf768 - comment - 24 Oct 2014

I was speaking about "Unpublished" when using batch-copy, Brian. They are unpublished here and should be.
For the rest, yes, you are right. Not sure it is an issue

avatar brianteeman
brianteeman - comment - 24 Oct 2014

Re the batch copy - they are published - see the video here http://youtu.be/iiVoftaBAZw

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4912.

avatar infograf768
infograf768 - comment - 24 Oct 2014

Can you test on staging?

avatar infograf768
infograf768 - comment - 24 Oct 2014
avatar brianteeman
brianteeman - comment - 24 Oct 2014

OK I can confirm on staging that batch copy defaults to unpublished. The first issue and the one I raised about the alias and the title are not effected by that PR and still occur in staging

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4912.

avatar infograf768
infograf768 - comment - 24 Oct 2014

Let's look at code.
When using save and copy, one already saves the copied item which is presented to edit (just do save and Copy and then close to confirm this). This means that all changes have to be made in the copy edited. Evidently, when saved the first time, it would not know about a new title therefore alias.

avatar joomdonation
joomdonation - comment - 24 Oct 2014

OK. I opened a PR to fix this issue. From a quick look at the code, it happens to Weblinks and Contacts as well. I will open new PR to fix it if the PR is approved.

avatar brianteeman
brianteeman - comment - 24 Oct 2014

Thank you!!!

On 24 October 2014 15:41, Tuan Pham Ngoc notifications@github.com wrote:

OK. I opened a PR to fix this issue. From a quick look at the code, it
happens to Weblinks and Contacts as well. I will open new PR to fix it if
the PR is approved.


Reply to this email directly or view it on GitHub
#4912 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman brianteeman - close - 24 Oct 2014
avatar zero-24 zero-24 - close - 24 Oct 2014
avatar brianteeman brianteeman - change - 24 Oct 2014
Status New Closed
Rel_Number 4916
Relation Type Related to
avatar brianteeman brianteeman - change - 24 Oct 2014
Closed_Date 0000-00-00 00:00:00 2014-10-24 14:59:53
avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment