[#47273] - [6.1] eslint config (stylistic)
- Pending
- Medium
- Build: 6.1-dev
- # 47273
- Diff
- heelc29:6.1/issue-45891-eslint
User tests: Successful: Unsuccessful:
Pull Request resolves #45891 and #46877 (comment).
Same as #47272 but for 6.1 to check new com_workflow files
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
- add
@stylistic/eslint-pluginto get basic code style checks for javascript files back - add
eslint-plugin-cypressto check files for system tests (cypress) and fix #47199 - update eslint config to use
eslint-plugin-vue - reapply #44852 to exit on warnings
- fix existing code style errors
Testing Instructions
run npm run lint:js and npm run lint:testjs
Actual result BEFORE applying this Pull Request
basic code style (indentation, comma, semicolon) is not checked
vue files are not checked
Expected result AFTER applying this Pull Request
basic code style (indentation, comma, semicolon) is checked (again)
vue files are checked
warnings results in exit code 1
Link to documentations
Please select:
- No documentation changes for guide.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change com_workflow Repository |
| Labels |
Added:
NPM Resource Changed
PR-6.1-dev
|
||
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
| Labels |
Added:
Conflicting Files
|
||
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has been automatically rebased to 6.2-dev.
| Title |
|
||||||
Should stay at 6.1 - at least the code style (checks) for new com_workflow
| Title |
|
||||||
| Labels |
Added:
Feature
PR-6.2-dev
|
||
We will not merge this in 6.1 so it can be rebased on 6.2, no feature for 6.1 anymore
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.