[#47273] - [6.2] update eslint config
- Closed
- 21 Jul 2026
- Medium
- Build: 6.1-dev
- # 47273
- Diff
- heelc29:6.1/issue-45891-eslint
User tests: Successful: Unsuccessful:
Pull Request resolves #45891 and #46877 (comment).
Same as #47272 but for 6.1 to check new com_workflow files
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
add@stylistic/eslint-pluginto get basic code style checks for javascript files backaddfix #47199eslint-plugin-cypressto check files for system tests (cypress) and- update eslint config to use
eslint-plugin-vue - reapply #44852 to exit on warnings
- fix existing code style errors
Testing Instructions
run npm run lint:js and npm run lint:testjs
Actual result BEFORE applying this Pull Request
basic code style (indentation, comma, semicolon) is not checked
vue files are not checked
Expected result AFTER applying this Pull Request
basic code style (indentation, comma, semicolon) is checked (again)
vue files are checked
warnings results in exit code 1
Link to documentations
Please select:
- No documentation changes for guide.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change com_workflow Repository |
| Labels |
Added:
NPM Resource Changed
PR-6.1-dev
|
||
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
| Labels |
Added:
Conflicting Files
|
||
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has been automatically rebased to 6.2-dev.
| Title |
|
||||||
Should stay at 6.1 - at least the code style (checks) for new com_workflow
| Title |
|
||||||
| Labels |
Added:
Feature
PR-6.2-dev
|
||
We will not merge this in 6.1 so it can be rebased on 6.2, no feature for 6.1 anymore
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
tecpromotion
- | Title |
|
||||||
| Labels |
Removed:
PR-6.1-dev
|
||
| Category | JavaScript Administration com_media NPM Change com_workflow Repository | ⇒ | Administration com_media NPM Change com_workflow JavaScript Repository Unit Tests |
| Labels |
Added:
Unit/System Tests
|
||
| Title |
|
||||||
We will not merge this in 6.1 so it can be rebased on 6.2, no feature for 6.1 anymore
reverted the added dev npm packages, so it's now a bug fix for the new com_workflow files
| Labels |
Added:
PR-6.1-dev
Removed: Conflicting Files |
||
It's not a bug if the code style doesn't look shiny as long as the code style checker is not complaining, improvements are only done in minor/major versions. I rebase this again to 6.2
| Title |
|
||||||
This pull request has conflicts, please resolve those before we can evaluate the pull request.
It's not a bug if the code style doesn't look shiny as long as the code style checker is not complaining, improvements are only done in minor/major versions. I rebase this again to 6.2
@HLeithner The code style checker is complaining (warnings).
> joomla@6.1.3 lint:js
> eslint --config build/eslint.config.mjs build administrator/components/com_media/resources/scripts
/__w/joomla-cms/joomla-cms/build/build-modules-js/javascript/build-com_workflow-js.mjs
20:3 warning Unused eslint-disable directive (no problems were reported from 'no-console')
81:9 warning Unused eslint-disable directive (no problems were reported from 'no-console')
85:7 warning Unused eslint-disable directive (no problems were reported from 'no-console')
90:7 warning Unused eslint-disable directive (no problems were reported from 'no-console')
99:3 warning Unused eslint-disable directive (no problems were reported from 'no-console')
101:3 warning Unused eslint-disable directive (no problems were reported from 'no-console')
165:5 warning Unused eslint-disable directive (no problems were reported from 'no-console')
167:5 warning Unused eslint-disable directive (no problems were reported from 'no-console')
/__w/joomla-cms/joomla-cms/build/media_source/vendor/jquery/js/jquery-noconflict.es6.js
1:1 warning Unused eslint-disable directive (no problems were reported from 'no-undef')
✖ 9 problems (0 errors, 9 warnings)
0 errors and 9 warnings potentially fixable with the `--fix` option.
As said don't do improvements in a bugfix release, this can introduce new bugs and does not fix existing onces, if I understand your pr correct.
Then I'll close this PR, since it has already been fixed in 6.2.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-07-21 10:16:27 |
| Closed_By | ⇒ | heelc29 | |
| Labels |
Added:
Conflicting Files
Removed: PR-6.2-dev |
||
thanks for your engagement and your understanding.
This pull request has conflicts, please resolve those before we can evaluate the pull request.