[#47272] - [5.4] update eslint config / remove cy.wait from tests
- Fixed in Code Base
- 10 Jul 2026
- Medium
- Build: 5.4-dev
- # 47272
- Diff
- heelc29:5.4/issue-45891-eslint
User tests: Successful: Unsuccessful:
Pull Request resolves #45891 #47199.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
add@stylistic/eslint-pluginto get basic code style checks for javascript files backaddfix #47199eslint-plugin-cypressto check files for system tests (cypress) and- update eslint config to use
eslint-plugin-vue - reapply #44852 to exit on warnings
- fix existing code style errors
Testing Instructions
run npm run lint:js and npm run lint:testjs
Actual result BEFORE applying this Pull Request
basic code style (indentation, comma, semicolon) is not checked
vue files are not checked
Expected result AFTER applying this Pull Request
basic code style (indentation, comma, semicolon) is checked (again)
vue files are checked
warnings results in exit code 1
Link to documentations
Please select:
- No documentation changes for guide.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change Repository Unit Tests |
| Labels |
Added:
Unit/System Tests
NPM Resource Changed
PR-5.4-dev
|
||
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
This pull request has conflicts, please resolve those before we can evaluate the pull request.
| Title |
|
||||||
Should stay at 5.4 - at least the code style fixes and replace waiting times at cypress tests
| Title |
|
||||||
| Labels |
Added:
Feature
Conflicting Files
PR-6.2-dev
|
||
| Labels |
Removed:
Conflicting Files
|
||
| Category | JavaScript Administration com_media NPM Change Repository Unit Tests | ⇒ | JavaScript Repository NPM Change Unit Tests |
| Category | JavaScript NPM Change Repository Unit Tests | ⇒ | Administration com_media NPM Change JavaScript Repository Unit Tests |
| Title |
|
||||||
I have tested this item ✅ successfully on de3a126
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47272.
I have tested this item ✅ successfully on de3a126
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47272.
I have tested this item ✅ successfully on de3a126
only the .vue files are checked, not .js files.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47272.
I have tested this item ✅ successfully on de3a126
only the .vue files are checked, not .js files.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47272.
I have tested this item ✅ successfully on de3a126
Tested changes in file \components\com_media\resources\scripts\components\browser\actionItems\delete.vue
- Changed ident in first line
- Had double ',,'
Unknown to the structure of *.vue i could not force an error with ';'
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47272.
I have tested this item ✅ successfully on de3a126
Tested changes in file \components\com_media\resources\scripts\components\browser\actionItems\delete.vue
- Changed ident in first line
- Had double ',,'
Unknown to the structure of *.vue i could not force an error with ';'
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47272.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47272.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47272.
| Labels |
Added:
RTC
Removed: PR-6.2-dev |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-07-10 12:56:18 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Removed:
Feature
|
||
Thanks @heelc29 for this PR, @laoneo for review, and @CSGoat0 and @ThomasFinnern for testing.
This pull request has been automatically rebased to 6.2-dev.