Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#47272] - [5.4] eslint config (stylistic)

Feature Unit/System Tests Conflicting Files NPM Resource Changed PR-5.4-dev PR-6.2-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
3 Mar 2026

Pull Request resolves #45891 .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

  • add @stylistic/eslint-plugin to get basic code style checks for javascript files back
  • add eslint-plugin-cypress to check files for system tests (cypress) and fix #47199
  • update eslint config to use eslint-plugin-vue
  • reapply #44852 to exit on warnings
  • fix existing code style errors

Testing Instructions

run npm run lint:js and npm run lint:testjs

Actual result BEFORE applying this Pull Request

basic code style (indentation, comma, semicolon) is not checked
vue files are not checked

Expected result AFTER applying this Pull Request

basic code style (indentation, comma, semicolon) is checked (again)
vue files are checked
warnings results in exit code 1

Link to documentations

Please select:

  • No documentation changes for guide.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 3 Mar 2026
avatar heelc29 heelc29 - change - 3 Mar 2026
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Mar 2026
Category ⇒ JavaScript Administration com_media NPM Change Repository Unit Tests
avatar heelc29 heelc29 - change - 3 Mar 2026
Labels Added: Unit/System Tests NPM Resource Changed PR-5.4-dev
avatar HLeithner
HLeithner - comment - 17 Mar 2026

This pull request has been automatically rebased to 6.2-dev.

avatar github-actions[bot]
github-actions[bot] - comment - 17 Mar 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

avatar HLeithner HLeithner - change - 17 Mar 2026
Title
…
[5.4] eslint config (stylistic)
[6.2] eslint config (stylistic)
avatar HLeithner HLeithner - edited - 17 Mar 2026
avatar heelc29
heelc29 - comment - 18 Mar 2026

Should stay at 5.4 - at least the code style fixes and replace waiting times at cypress tests

avatar heelc29 heelc29 - change - 18 Mar 2026
Title
…
[6.2] eslint config (stylistic)
[5.4] eslint config (stylistic)
avatar heelc29 heelc29 - edited - 18 Mar 2026
avatar heelc29 heelc29 - change - 18 Mar 2026
Labels Added: Feature Conflicting Files PR-6.2-dev

Add a Comment

Login with GitHub to post a comment