[#47274] - [5.4] fix missing joomla version in nightly notification
- Fixed in Code Base
- 13 Mar 2026
- Medium
- Build: 5.4-dev
- # 47274
- Diff
- heelc29:5.4/nightly-notification
User tests: Successful: Unsuccessful:
Pull Request resolves
The nightly builds are sending a message of success or failure to channels/pd-att-ci-notifications
Unfortunately the message just states "Joomla", not the specific nightly build that is being created.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
variable is not resolved with double quotation marks
Testing Instructions
code review
Actual result BEFORE applying this Pull Request
links doesn't contain minor version
Expected result AFTER applying this Pull Request
links should contain minor version
Link to documentations
Please select:
- No documentation changes for guide.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
| Labels |
Added:
Unit/System Tests
PR-5.4-dev
|
||
| Labels |
Added:
bug
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-03-13 15:36:59 |
| Closed_By | ⇒ | richard67 |
Thanks a lot @heelc29 for this PR, and @HLeithner for help with signing.
@heelc29 After this PR has been merged, I have triggered a nightly build. The upload step failed with following message:
+ rclone delete nightly:/home/******/public_html/nightlies/ --include "Joomla_$MINORVERSION.*"
+ rclone delete nightly:/home/******/public_html/cache/com_content/
+ rclone copy ./transfer/ nightly:/home/******/public_html/nightlies/
/bin/sh: 74: Syntax error: "(" unexpected
And the buildfailure step shows:
export MINORVERSION=5.4
/bin/sh: 41: Syntax error: "(" unexpected
See https://ci.joomla.org/joomla/joomla-cms/92016/2/3
What is weird: Here it seems the nightly build which I have triggered after the merge has worked: https://developer.joomla.org/nightly-builds.html
Updated hash, can be merged