? Error

User tests: Successful: Unsuccessful:

avatar prokyhb
prokyhb
14 Oct 2014

$('tr[parents*=" '+parentId+'"]'); - selects parent id 2, 2[0..9] etc. so when there are a lot of categories, sorting does not work properly.

'tr[parents~="'+parentId+'"] - this select exact phrase selected by space or at the beggining or the end of attribute value.

http://api.jquery.com/category/selectors/attribute-selectors/

avatar prokyhb prokyhb - open - 14 Oct 2014
avatar jissues-bot jissues-bot - change - 14 Oct 2014
Labels Added: ?
avatar nicksavov nicksavov - change - 16 Oct 2014
Labels Added: ?
avatar mrunalpittalia
mrunalpittalia - comment - 17 Oct 2014

@test

Hello prokyhb,
Can you please provide more information on how to test the fix?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4665.

avatar prokyhb
prokyhb - comment - 17 Oct 2014

Hi mrunalpittalia,

of course. I have attached sql dump of jos_categories with data, that are in situation, when the bug appears. Try to move categories 92 or 99.

Cheers, Jan.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4665.

avatar prokyhb
prokyhb - comment - 17 Oct 2014

Ok, zip or sql files are not allowed here. Download link: Your text to link here...

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4665.

avatar compojoom
compojoom - comment - 17 Oct 2014

Thank you for the sql dump. I tested it and your patch resolves the issue.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4665.

avatar compojoom compojoom - test_item - 17 Oct 2014 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 17 Oct 2014

@test OK

Tested in the provided sample and in a clean installation with the classic categories

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4665.

avatar anibalsanchez
anibalsanchez - comment - 17 Oct 2014

BTW: compojoom - comment - 17 Oct 14 "I tested it and your patch resolves the issue." @test OK

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4665.

avatar brianteeman brianteeman - change - 17 Oct 2014
Category JavaScript
avatar prokyhb prokyhb - test_item - 18 Oct 2014 - Tested successfully
avatar brianteeman brianteeman - alter_testresult - 28 Oct 2014 - anibalsanchez: Tested successfully
avatar brianteeman
brianteeman - comment - 28 Oct 2014

Multiple good tests - thanks - setting to RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4665.

avatar brianteeman brianteeman - change - 28 Oct 2014
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 29 Nov 2014
Labels Added: ?
avatar Bakual
Bakual - comment - 2 Dec 2014

Merged into staging. Thanks!

avatar Bakual Bakual - change - 2 Dec 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-12-02 19:33:39
avatar Bakual Bakual - close - 2 Dec 2014
avatar zero-24 zero-24 - close - 2 Dec 2014
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment