[#4666] - History or versions
- Closed
- 17 Oct 2014
- Medium
- Build: staging
- # 4666
- Diff
- brianteeman:patch-1
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
I was trying to see why I didnt have the versions button in the content editor of one site.
Finally I discovered in the options that the option is labelled as History not versions. In my opinion this is confusing. If I am looking for the versions feature it should be labelled versions not history.
This PR changes the label to say Versions
As you can see it now says Save Versions and Maximum Versions and not Save History and Maximum Versions which I believe to be confusing
Votes
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Language & Strings |
In the context you are probably correct George. I will update the PR
On 14 October 2014 13:15, George Wilson notifications@github.com wrote:
"Save versions" to me doesn't sound right. Something like "Use
Versioning?" makes more sense if you want to use the word version—
Reply to this email directly or view it on GitHub
#4666 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I went for "Enable Versions"
This should go into 3.4.0
| Labels |
Added:
?
|
||
Setting to RTC based on comments (no tests needed). According to JM please merge into 3.4-dev
I'll make sure it gets put into 3.4
| Labels |
Added:
?
|
||
PBF Demo: Tested and after applying the patch, the text changes to Enable Versions.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4666.
| Status | Pending | ⇒ | Ready to Commit |
@test failed. I applied the patch using git apply and using Joomla! Patch Tester, but the text remained as
Maximum Versions:
http://awesomescreenshot.com/0993oe2217
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4666.
@dimitargsg that is the NEW string
The original was history the new is versions
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4666.
It says "Enable versions" for me too
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4666.
I am sorry, I was confused by the comments. In this case, my test was successful as well :)
@dimitargsg thanks - can be confusing this stuff especially when its not your first language
@superfoght yes that is correct that it the changed and desired behaviour
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4666.
Merged into 3.4.-dev. Thanks!
zero-24
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-17 11:04:29 |
| Labels |
Removed:
?
|
||
joomla-cms-bot
- | Labels |
Added:
?
|
||
"Save versions" to me doesn't sound right. Something like "Use Versioning?" makes more sense if you want to use the word version