? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
14 Oct 2014
Moving current code to bootstrap modal

Same as #4661 #4645 #4575 #4563 #4561 #4514 #4513

Testing:
After Applying this patch
Try editing an article and use the editor’s buttons

Preview:
screenshot 2014-10-14 07 48 07
screenshot 2014-10-14 07 48 24
screenshot 2014-10-14 07 48 39

avatar dgt41 dgt41 - open - 14 Oct 2014
avatar jissues-bot jissues-bot - change - 14 Oct 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 14 Oct 2014
Category Templates (admin) UI/UX
avatar dgt41
dgt41 - comment - 14 Oct 2014

This one AS IT IS BREAKS B/C.
All needed is a proxy from
SqueezeBox.close();
to
jQuery("#menusModuleModal").modal("hide”);
Anyone?

avatar Fedik
Fedik - comment - 14 Oct 2014

I do not see b/c problem in replace SqueezeBox.close(); to jQuery("#menusModuleModal").modal("hide”); ...
or you got some problem with it?

avatar infograf768
infograf768 - comment - 14 Oct 2014

@test

results here (Firefox Macintosh) are quite frustrating:
browser window set to 744px:
744px
Browser window set to 830px
830px

avatar infograf768
infograf768 - comment - 14 Oct 2014

Forget it. This one is missing the css found in #4514
once the css are in. it's OK

avatar dgt41
dgt41 - comment - 14 Oct 2014

@Fedik The problem will be as follow:
Someone got a button from a 3rd party dev.
This button does some fancy staff and on save it closes the modal.
Ooops problem because calling SqueezeBox.close(); won’t do anything.
I STRONGLY believe that we should (only on this PR) have a proxy for the old close function
Unless if we are SURE that NOBODY ever calls this function [honestly I don’t use those buttons at all so I am not the one to certify that]

avatar dgt41
dgt41 - comment - 14 Oct 2014

Update @Fedik Looking at the available buttons on extensions directory there is no such plugin available, so I have to admit that I WAS WRONG.

avatar dgt41
dgt41 - comment - 14 Oct 2014

@infograf768 I didn’t push the less/css changes in every PR for the shake of simplicity. I will update the description for a proper way of testing

avatar Fedik
Fedik - comment - 14 Oct 2014

@dgt41 even if someone use it, he/she use it with behavior.modal and not with bootstrap.modal, as I understand :smile:

0f34dc8 14 Oct 2014 avatar dgt41 CSS
avatar dgt41 dgt41 - change - 14 Oct 2014
The description was changed
avatar nicksavov nicksavov - change - 16 Oct 2014
The description was changed
Labels Added: ?
avatar trangredweb
trangredweb - comment - 17 Oct 2014
avatar trangredweb trangredweb - test_item - 17 Oct 2014 - Tested successfully
avatar luredweb
luredweb - comment - 17 Oct 2014

@test

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4664.

avatar luredweb luredweb - test_item - 17 Oct 2014 - Tested successfully
avatar kienlc
kienlc - comment - 17 Oct 2014
avatar rajeshstarlite
rajeshstarlite - comment - 17 Oct 2014

@test, Modal box works fine in my test but in IE8 some CSS problem. Please take a look at attached screen shot.
screen shot 2014-10-17 at 02 26 10

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4664.

avatar rajeshstarlite rajeshstarlite - test_item - 17 Oct 2014 - Tested unsuccessfully
avatar jcata jcata - test_item - 17 Oct 2014 - Tested successfully
avatar gunjanpatel
gunjanpatel - comment - 17 Oct 2014

@luredweb and @trangredweb can you please confirm that you are not able to reproduce the issue on IE8. Because, @ rajeshstarlite experienced the issue with IE8. Please confirm, so we may ready to commit. Right now it's not possible to move RTC.
Thanks all.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4664.

avatar micker
micker - comment - 17 Oct 2014

i can't test it

_Error

The patch could not be applied because it conflicts with a previously applied patch: administrator/templates/isis/css/template-rtl.css_


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4664.

avatar gunjanpatel
gunjanpatel - comment - 17 Oct 2014

@micker try to apply patch manually using https://github.com/joomla/joomla-cms/pull/4664.diff or you may try to revert your other patch which you have applied.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4664.

avatar luredweb
luredweb - comment - 17 Oct 2014

yes, @gunjanpatel, I tested IE8 it's some CSS problem in IE8 as @rajeshstarlite

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4664.

avatar brianteeman
brianteeman - comment - 17 Oct 2014

@micker you need to always revert a patch before applying another one - this makes sure that you are always testing just one patch

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4664.

avatar dgt41
dgt41 - comment - 17 Oct 2014

@all IE8 doesn’t support css3, thus the sharp angles. This is also the way Bootstrap itself works. I don’t think we should invest time trying to make bootstrap modals look good on IE8

avatar gunjanpatel gunjanpatel - change - 17 Oct 2014
Status Pending Ready to Commit
avatar gunjanpatel
gunjanpatel - comment - 17 Oct 2014

Thanks. Moving to RTC as we have more than 3 successfull tests.

avatar gunjanpatel
gunjanpatel - comment - 17 Oct 2014

Sorry for typo in above comment. We have 3 successfull test so moving RTC. :)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4664.

avatar brianteeman brianteeman - change - 17 Oct 2014
Status Ready to Commit Needs Review
avatar dgt41
dgt41 - comment - 17 Oct 2014

@brianteeman and the rest of the PLT:
WARNING
This PR might have negative impact in the front end templates, if no bootstrap css is loaded!

avatar AlexVeSo AlexVeSo - test_item - 17 Oct 2014 - Tested successfully
avatar dgt41
dgt41 - comment - 17 Oct 2014

I am closing this. PLEASE DO NOT COMMIT.

avatar dgt41 dgt41 - close - 17 Oct 2014
avatar dgt41 dgt41 - close - 17 Oct 2014
avatar dgt41 dgt41 - change - 17 Oct 2014
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2014-10-17 17:26:48
avatar dgt41 dgt41 - head_ref_deleted - 14 Dec 2014

Add a Comment

Login with GitHub to post a comment