[#46090] - [5.3] Joomla Dialog add support for aria-label
- Fixed in Code Base
- 20 Sep 2025
- Medium
- Build: 5.3-dev
- # 46090
- Diff
- Fedik:dialog-aria-label3
User tests: Successful: Unsuccessful:
Pull Request for Issue #45429
Summary of Changes
Add support for aria-label and aria-labelledby attributes for dialog in the JoomlaDialog.
The attributes can be set manually during dialog creation.
When it is empty the attribute will be set automatically based on the header text.
Testing Instructions
Apply patch.
Run npm install.
Open any dialog in backend and check source code for it.
Actual result BEFORE applying this Pull Request
Dialog does not have aria-label attribute
Expected result AFTER applying this Pull Request
Dialog has an aria-label attribute.
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: TBD
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Title |
|
||||||
I have tested this item ✅ successfully on 8894fd9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46090.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46090.
I have tested this item ✅ successfully on 8894fd9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46090.
| Labels |
Added:
RTC
a11y
NPM Resource Changed
bug
PR-5.3-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-09-20 08:20:25 |
| Closed_By | ⇒ | LadySolveig |
Thank you for the fix @Fedik great teamwork - bringing up and clarifying the issue and also for testing @ceford @alikon @brianteeman @chmst @bembelimen
I have tested this item ✅ successfully on 8894fd9
With the patch, the Batch process dialog has this:
Without the patch the aria-label is absent.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46090.