Feature PR-6.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
13 Sep 2025

Pull Request for Issue #45429

Summary of Changes

Add support for aria-label and aria-labelledby attributes for dialog in the JoomlaDialog.
The attributes can be set manually during dialog creation.
When it is empty the attribute will be set automatically based on the header text.

Testing Instructions

Apply patch.
Run npm install.
Open any dialog in backend and check source code for it.

Actual result BEFORE applying this Pull Request

Dialog does not have aria-label attribute

Expected result AFTER applying this Pull Request

Dialog has an aria-label attribute.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: TBD
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 13 Sep 2025
avatar Fedik Fedik - change - 13 Sep 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2025
Category Repository Administration com_associations com_content com_fields com_joomlaupdate com_menus com_users
avatar brianteeman
brianteeman - comment - 13 Sep 2025

This is a bug fix not a new feature

avatar Fedik
Fedik - comment - 13 Sep 2025

It adds new properties, so new feature 😉
I can change to 5.4.

avatar Fedik Fedik - close - 13 Sep 2025
avatar Fedik
Fedik - comment - 13 Sep 2025

I changed to 5.3 #46090

avatar Fedik Fedik - change - 13 Sep 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-09-13 09:28:37
Closed_By Fedik
Labels Added: Feature PR-6.1-dev

Add a Comment

Login with GitHub to post a comment