[#46091] - Update core.es6.js
- Pending
- Medium
- Build: 5.3-dev
- # 46091
- Diff
- hans2103:patch-2
User tests: Successful: Unsuccessful:
Allow elements figure and figcaption to be used in popupContent of Joomla-Dialog
Summary of Changes
This PR will add figure and figcaption to the list of allowed elements in popupContent
Testing Instructions
- create a dialog as described on https://manual.joomla.org/docs/general-concepts/javascript/js-library/joomla-dialog/ and use
popupContent. - fill the popupContent with html including a
figurecontaining an image andfigcaption - render the page containing the dialog
- open the dialog and inspect the code
Actual result BEFORE applying this Pull Request
- notice the
figureelement is removed and the image is not shown, because of the removed figure element containing the image
Expected result AFTER applying this Pull Request
- notice both
figureandfigcaptionare present and the image is shown
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
@hans2103 since you're at it could you also add popovertarget and popovertargetaction to the button and popover in the div? ref: https://developer.mozilla.org/en-US/docs/Web/API/Popover_API
| Labels |
Added:
NPM Resource Changed
PR-5.3-dev
|
||
Can you maybe also add other Content elements? https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements#content_sectioning
@hans2103 since you're at it could you also add popovertarget and popovertargetaction to the button and popover in the div? ref: https://developer.mozilla.org/en-US/docs/Web/API/Popover_API
Both suggestions are legit but out of scope for me at this moment.
Please test and approve this PR. Adding other elements should be done and tested in a separate issue.
This pull request has been automatically rebased to 5.4-dev.
This pull request has been automatically rebased to 6.1-dev.
Can you maybe also add other Content elements? https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements#content_sectioning