[#44856] - [6.0] should-be-enough-even-for-edge-case
- Closed
- 24 Mar 2025
- Medium
- Build: 5.3-dev
- # 44856
- Diff
- alikon:patch-21
User tests: Successful: Unsuccessful:
Pull Request for Issue #42376 , #38835 .
redo of #42765 for sql custom field
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
Yea, that can work
I think we should not set the default value to that high number. Not my field, so I asked Chat GTP and it gives good explanation for what I think about:
Performance Issues – If the dropdown contains a large dataset, displaying too many results can slow down rendering and affect user experience.
UI Clutter – Too many search results can make the dropdown overwhelming and difficult to navigate.
Strange that it also recommends use 10 for the parameters (maybe it already read our code :D).
If users cannot find the items they are looking for, they need to enter a more accurate keyword for searching.
| Labels |
Added:
Feature
NPM Resource Changed
PR-5.3-dev
|
||
This pull request has been automatically rebased to 6.0-dev.
| Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-03-24 21:40:23 |
| Closed_By | ⇒ | alikon | |
| Labels |
Added:
PR-6.0-dev
Removed: PR-5.3-dev |
||
i'll not invest much more time on this
@joomdonation I believe your comment was mistaken. The list will already contain an unlimited number of items as the renderchoicelimit is set to unlimited https://github.com/Choices-js/Choices?tab=readme-ov-file#renderchoicelimit So any argument about the searchResultLimit being too long is mute as it will always be less than the unlimited number of items listed. This PR should be re-opened but without any limit on the number of search results
follow-up to #44794