Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#44857] - [5.3] Improve system skipto plugin code

RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
11 Feb 2025

Pull Request for Issue # .

Summary of Changes

Just a small change to System - Skip-To Navigation plugin: Introduce $language variable to avoid repeat call to get language object.

Testing Instructions

  • Honestly, I do not know how to use this feature. So if you want to test it, just use Joomla 5.3, then apply patch, access to administrator area of your site and confirm that it is still loading OK.
  • Code review should be enough, too. It is just a simple change, and I am not doing this by hand. I just use phpstorm refactor feature to introduce this variable, so that should not be any mistake

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 11 Feb 2025
avatar joomdonation joomdonation - change - 11 Feb 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Feb 2025
Category ⇒ Front End Plugins
avatar fgsw fgsw - test_item - 12 Feb 2025 - Tested successfully
avatar fgsw
fgsw - comment - 12 Feb 2025

I have tested this item ✅ successfully on 7cb8cf3

Start Plugin by access key "Ctrl+Option+9" (Mac), navigate using Keyboard:

Backend Frontend
be fe
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44857.
avatar laoneo laoneo - change - 12 Feb 2025
Labels Added: PR-5.3-dev
avatar QuyTon QuyTon - test_item - 12 Feb 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 12 Feb 2025

I have tested this item ✅ successfully on e022332

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44857.

avatar QuyTon QuyTon - alter_testresult - 12 Feb 2025 - fgsw: Tested successfully
avatar QuyTon QuyTon - change - 12 Feb 2025
Status Pending ⇒ Ready to Commit
avatar QuyTon
QuyTon - comment - 12 Feb 2025

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44857.

avatar laoneo laoneo - change - 12 Feb 2025
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-02-12 07:26:41
Closed_By ⇒ laoneo
Labels Added: RTC
avatar laoneo laoneo - close - 12 Feb 2025
avatar laoneo laoneo - merge - 12 Feb 2025
avatar laoneo
laoneo - comment - 12 Feb 2025

Thanks!

avatar joomdonation
joomdonation - comment - 12 Feb 2025

Thanks all for your help !

Add a Comment

Login with GitHub to post a comment