NPM Resource Changed PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
11 Feb 2025

Pull Request for Issue #44853 .

Summary of Changes

Restrict the js for collapsing accordions etc to relevant elements in the header

Steps to reproduce the issue

in a back-end view ./administrator/components/com_content/tmpl/articles/default.php create an accordion with the joomla core htmlhelpers, add the following lines before the line starting with <form action=

<?php echo HTMLHelper::_('bootstrap.startAccordion', 'accordion-test'); ?>
<?php echo HTMLHelper::_('bootstrap.addSlide', 'accordion-test', Text::_('TEST'), 'test-collapse', 'test'); ?>
   <h1>TEST-ACCORDION</h1>
<?php echo HTMLHelper::_('bootstrap.endSlide'); ?>
<?php echo HTMLHelper::_('bootstrap.endAccordion'); ?>

When you now go to the view articles, you see the closed accordion.
Click on the accordion to open it.
The accordion opens.

now click on the topbar menu 'User Menu'

The accordion now closes although it should stay open.

Actual result BEFORE applying this Pull Request

The article accordion collapses when opening the user menu or tourguide dropdown

Expected result AFTER applying this Pull Request

The article accordion remains open when opening the user menu or tourguide dropdown

Testing

As this is a js change you will need to either run npm i or use a prebuilt package

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 11 Feb 2025
avatar brianteeman brianteeman - change - 11 Feb 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Feb 2025
Category JavaScript Repository NPM Change
avatar brianteeman brianteeman - change - 11 Feb 2025
The description was changed
avatar brianteeman brianteeman - edited - 11 Feb 2025
avatar brianteeman brianteeman - change - 11 Feb 2025
Labels Added: NPM Resource Changed PR-5.3-dev
avatar Ruud68 Ruud68 - test_item - 11 Feb 2025 - Tested successfully
avatar Ruud68
Ruud68 - comment - 11 Feb 2025

I have tested this item ✅ successfully on 101cefc

Works! Thanks @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44858.

avatar ceford ceford - test_item - 12 Feb 2025 - Tested successfully
avatar ceford
ceford - comment - 12 Feb 2025

I have tested this item ✅ successfully on 101cefc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44858.

avatar richard67 richard67 - change - 12 Feb 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 12 Feb 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44858.

Add a Comment

Login with GitHub to post a comment