Feeling Lucky
RTC
PR-5.3-dev
[#44855] - [5.3] Improve System - Keyboard Shortcuts plugin code
- Fixed in Code Base
- 12 Feb 2025
- Medium
- Build: 5.3-dev
- # 44855
- Diff
- joomdonation:improve_system_shortcut_plugin
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Like similar PRs, this PR improves code of System - Keyboard Shortcuts:
- Introduce local variables $app, $language to avoid repeat call to methods to get object. That would make the system runs slight faster.
- Add missing $event parameter for initialize method
- Declare void return type for event listener methods
Testing Instructions
- Use Joomla 5.3 nightly build
- Apply patch, confirm that Keyboard Shortcuts still work as before. For example, go to Articles Management screen, press J, then N and confirm that add article screen is displayed (same as you press New button in the toolbar)
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
richard67
- comment
- 12 Feb 2025
I have tested this item ✅ successfully on f17f359
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44855.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.3-dev
|
||
richard67
- comment
- 12 Feb 2025
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44855.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-12 11:10:44 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
RTC
|
||
laoneo
- comment
- 12 Feb 2025
Thanks!
joomdonation
- comment
- 12 Feb 2025
Thank you all !
I have tested this item ✅ successfully on f17f359
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44855.