Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#44747] - Fix multi select behavior in Media Manager followup of 39824

RTC NPM Resource Changed PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar MacJoom
MacJoom
18 Jan 2025

Pull Request for Issue #33637
This is a followup of #39824

All the credits go @rajputanuj31 - i just fixed the conflicts and could not do it against his PR

Summary of Changes

In Media Manager selecting multiple files with the ctrl key does not work - this is fixed with this PR

Testing Instructions

Go to Media Manager try to select multiple files with the CTRL key

Actual result BEFORE applying this Pull Request

Already selected file is unselected, not possible to select multiple files this way

Expected result AFTER applying this Pull Request

Selecting multiple files is possible

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar MacJoom MacJoom - open - 18 Jan 2025
avatar MacJoom MacJoom - change - 18 Jan 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jan 2025
Category ⇒ Administration com_media NPM Change JavaScript
avatar richard67
richard67 - comment - 18 Jan 2025

@MacJoom Does this PR replace #39824 so the latter should be closed?

avatar MacJoom
MacJoom - comment - 18 Jan 2025

@MacJoom Does this PR replace #39824 so the latter should be closed?

Yes can be closed - thanks

avatar fgsw fgsw - test_item - 19 Jan 2025 - Tested successfully
avatar fgsw
fgsw - comment - 19 Jan 2025

I have tested this item ✅ successfully on bdd34b1

Hint: Test on Mac use Command-Key:

Untitled

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44747.
avatar LadySolveig LadySolveig - test_item - 19 Jan 2025 - Tested unsuccessfully
avatar LadySolveig
LadySolveig - comment - 19 Jan 2025

I have tested this item 🔴 unsuccessfully on bdd34b1

Selecting multiple files with ctrl key is working fine now, but I am unable to select a folder after applying this PR.
grafik

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44747.
avatar richard67
richard67 - comment - 19 Jan 2025

I have tested this item 🔴 unsuccessfully on bdd34b1Selecting multiple files with ctrl key is working fine now, but I am unable to select a folder after applying this PR.

Confirmed.

avatar richard67 richard67 - change - 19 Jan 2025
Labels Added: NPM Resource Changed PR-5.2-dev
avatar richard67 richard67 - test_item - 19 Jan 2025 - Tested successfully
avatar richard67
richard67 - comment - 19 Jan 2025

I have tested this item ✅ successfully on 74083ef

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44747.

avatar LadySolveig LadySolveig - test_item - 19 Jan 2025 - Tested successfully
avatar LadySolveig
LadySolveig - comment - 19 Jan 2025

I have tested this item ✅ successfully on 74083ef

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44747.

avatar richard67 richard67 - change - 19 Jan 2025
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 19 Jan 2025

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44747.

avatar Hackwar Hackwar - change - 19 Jan 2025
Labels Added: RTC
avatar Hackwar Hackwar - change - 19 Jan 2025
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-01-19 14:48:12
Closed_By ⇒ Hackwar
avatar Hackwar Hackwar - close - 19 Jan 2025
avatar Hackwar Hackwar - merge - 19 Jan 2025
avatar Hackwar
Hackwar - comment - 19 Jan 2025

Thank you!

Add a Comment

Login with GitHub to post a comment