[#44750] - [5.2] Refactored JDatabaseDriver in some params
- Fixed in Code Base
- 20 Jan 2025
- Medium
- Build: 5.2-dev
- # 44750
- Diff
- pe7er:refactoring-jdatabasedriver
User tests: Successful: Unsuccessful:
Refactored JDatabaseDriver to Joomla\Database\DatabaseDriver
Summary of Changes
Refactored some params to use Joomla\Database\DatabaseDriver instead
Testing Instructions
Code review
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Installation |
I have tested this item ✅ successfully on c855172
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44750.
I have not tested this item.
Reverting my test result as I hadn't seen @Hackwar 's comment.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44750.
Are you sure that it should be DatabaseDriver and not DatabaseDriverInterface?
No, I'm not. I chose to replace JDatabaseDriver with DatabaseDriver because
plugins/behaviour/compat/src/classmap/classmap.php states
JLoader::registerAlias('JDatabaseDriver', '\Joomla\Database\DatabaseDriver', '6.0');
If it should be DatabaseDriverInterface, could you please correct it?
Yes please change it to the interface as the model doesn't get the concrete class injected.
| Labels |
Added:
PR-5.2-dev
Code Review
|
||
Yes please change it to the interface as the model doesn't get the concrete class injected.
Thanks!
I've refactored \JDatabaseDriver to DatabaseInterface
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-01-20 13:05:16 |
| Closed_By | ⇒ | Hackwar |
Are you sure that it should be DatabaseDriver and not DatabaseDriverInterface?