RTC Composer Dependency Changed bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
18 Jan 2025

Pull Request for Issue #38532 (part) .

See #38532 (comment) .

Summary of Changes

This pull request (PR) updates the composer dependency "enshrined/svg-sanitize" from 0.20.0 to the next version 0.21.0.

This fixes the upload of SVG files which contain a dominant-baseline attribute.

See darylldoyle/svg-sanitizer#112 and https://github.com/darylldoyle/svg-sanitizer/releases/tag/0.21.0 .

Testing Instructions

Set media options to allow svg files (allowed extensions), svg image files and image/svg+xml mimetype.

Go to media manager

Upload an SVG file which contains a dominant-baseline attribute.

You can download the SVG file from this issue darylldoyle/svg-sanitizer#111 here: svg-file .

Actual result BEFORE applying this Pull Request

Error "Unable to upload file".

Expected result AFTER applying this Pull Request

SVG file is uploaded and shows in media manager.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 18 Jan 2025
avatar richard67 richard67 - change - 18 Jan 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jan 2025
Category External Library Composer Change
avatar richard67 richard67 - change - 18 Jan 2025
The description was changed
avatar richard67 richard67 - edited - 18 Jan 2025
avatar richard67 richard67 - change - 18 Jan 2025
The description was changed
avatar richard67 richard67 - edited - 18 Jan 2025
avatar richard67 richard67 - change - 18 Jan 2025
The description was changed
avatar richard67 richard67 - edited - 18 Jan 2025
avatar richard67 richard67 - change - 18 Jan 2025
The description was changed
avatar richard67 richard67 - edited - 18 Jan 2025
avatar richard67 richard67 - change - 18 Jan 2025
The description was changed
avatar richard67 richard67 - edited - 18 Jan 2025
avatar MacJoom MacJoom - test_item - 18 Jan 2025 - Tested successfully
avatar MacJoom
MacJoom - comment - 18 Jan 2025

I have tested this item ✅ successfully on a040824

Used the prebuilt packages. Previously suspicous file works now (taken from within darylldoyle/svg-sanitizer#111)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44746.

avatar richard67 richard67 - change - 18 Jan 2025
The description was changed
avatar richard67 richard67 - edited - 18 Jan 2025
avatar richard67 richard67 - change - 18 Jan 2025
The description was changed
avatar richard67 richard67 - edited - 18 Jan 2025
avatar dautrich dautrich - test_item - 18 Jan 2025 - Tested successfully
avatar dautrich
dautrich - comment - 18 Jan 2025

I have tested this item ✅ successfully on a040824


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44746.

avatar richard67 richard67 - change - 18 Jan 2025
Status Pending Ready to Commit
Labels Added: bug Composer Dependency Changed PR-5.2-dev
avatar richard67
richard67 - comment - 18 Jan 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44746.

avatar Hackwar Hackwar - change - 18 Jan 2025
Labels Added: RTC
avatar Hackwar Hackwar - close - 18 Jan 2025
avatar Hackwar Hackwar - merge - 18 Jan 2025
avatar Hackwar Hackwar - change - 18 Jan 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-01-18 20:25:15
Closed_By Hackwar
avatar Hackwar
Hackwar - comment - 18 Jan 2025

Thank you!

Add a Comment

Login with GitHub to post a comment