[#44745] - [5.2] Fix media downloads with spaces followup of #37396
- Fixed in Code Base
- 18 Jan 2025
- Medium
- Build: 5.2-dev
- # 44745
- Diff
- MacJoom:fix-media-download-followup-37396
User tests: Successful: Unsuccessful:
Pull Request for Issue #37369.
Please check the comments there.
Thanks to https://github.com/Vanshitasingh for the original PR
fixed the Download text from the second character to the whole name
Summary Of Changes
Fixed Media Downloads with Spaces
Testing Instructions
Replaced '%20' with space gaps using replace function.
Actual result BEFORE applying this Pull Request
The file with spaces in it loses everything between the first and second space.
Expected result AFTER applying this Pull Request
spaces are kept intact.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.2-dev
|
||
I have tested this item ✅ successfully on c226b4f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44745.
I have tested this item ✅ successfully on c226b4f
Tested again successfully
Before PR
After PR
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44745.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44745.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-01-18 15:52:58 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
RTC
|
||
I have tested this item ✅ successfully on 0b14cc3
I tested this PR and it fixes the issue
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44745.