[#43199] - [5]- move system stats plugin to task plugin
- Closed
- 11 Apr 2024
- Medium
- Build: 5.1-dev
- # 43199
- Diff
- alikon:move-stats2task
User tests: Successful: Unsuccessful:
Summary of Changes
move system stats plugin to task plugin
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
| Labels |
Added:
Language Change
PR-5.1-dev
|
||
| Category | Administration Language & Strings Front End Plugins | ⇒ | Administration com_admin SQL Postgresql Language & Strings Installation Libraries Front End Plugins |
| Category | Administration Language & Strings Front End Plugins com_admin SQL Postgresql Installation Libraries | ⇒ | Administration com_admin SQL Postgresql Language & Strings Installation Libraries Front End Plugins JavaScript Unit Tests |
| Labels |
Added:
Unit/System Tests
|
||
I'd leave this one as a system plugin - doesn't stop you moving the sending of the data to the task events (don't forget plugin groups are just how the plugins are loaded) doesn't stop you using other events.
So leave it as a system - because we still need to get consent from the user - but then use the task infrastructure for sending the data.
we still need to get consent from the user
and we are getting it, cause the user need to schedule that task... so you are more than informed
| Title |
|
||||||
I have tested this item ? unsuccessfully on 7ed72c0
Could not reproduce, Systems Stats remains as stats plugin, not moved to task plugin after patch applied
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43199.
@growunder It is not sufficient just to apply the patch, it also needs to run the SQL statement in the update SQL script added by this PR. Or use the packages created by drone for this PR.
@alikon Would be good to have testing instructions so testers know what to do.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-11 18:59:16 |
| Closed_By | ⇒ | alikon |
1st we should get some consensus, and as for now we don't get it.... so
System tests are failing for new installation (regardless of database type). Reason could be that the statistics message is not shown as it should be after a new installation.