[#43198] - [4.4] Form Text Field: Translate text for frontend validation
- Fixed in Code Base
- 9 Aug 2024
- Medium
- Build: 4.4-dev
- # 43198
- Diff
- Hackwar:4.4-field-translate
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #42919 .
Summary of Changes
The validation text for frontend validation right now is not translated.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
That might be, however that would be a refactoring and a new feature, which we can only really do in a major or minor release, not in a patch release. Fixing the bug for now however would be possible for 4.4, which means people on 4.4 and 5.1 would both benefit from this now instead of having to wait for 5.2.
I'm not sure what's the new feature here. All I said is that instead changing this in the layout you should doit in the form class. The same conditional, essentially the same code, but in the right place using the existing API for the data.
Anyways, monkey patching is also fine...
I have tested this item ✅ successfully on ebd2d9f
tested by adding validationtext="JGLOBAL_TITLE" to the title field of administrator\components\com_content\forms\article.xml
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43198.
I have tested this item ✅ successfully on ebd2d9f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43198.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-4.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43198.
| Status | Ready to Commit | ⇒ | Pending |
I have tested this item ? unsuccessfully on ebd2d9f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43198.
changed my test result as it needs to be escaped as Fedir pointed out.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43198.
@Quy @brianteeman I escaped the string. Would you be able to test this again?
I have tested this item ✅ successfully on 8baa931
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43198.
I have tested this item ✅ successfully on 8baa931
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43198.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43198.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-09 06:32:59 |
| Closed_By | ⇒ | laoneo |
Thanks!
The way to set the
dataattributes of an element should be done through the existing API. The existing code predates the API...In sort this should be done differently