[#43200] - [5.1] Full path in error log
- Closed
- 3 Apr 2024
- Medium
- Build: 5.1-dev
- # 43200
- Diff
- brianteeman:branch
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
This PR changes the error message so that the full path and not just the filename is displayed in the error log
Pull Request for Issue #43105 .
Testing Instructions
see original issue
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
@brianteeman The error message from the issue seems to come from the filesystem library of the framework (Joomla\Filesystem\File::delete) and not from the CMS filesystem library (Joomla\CMS\Filesystem\File::delete) which you modify here.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-03 10:48:37 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
PR-5.1-dev
|
||
guess this should be closed then and a pr made upstream
@brianteeman The code line which produces the error message from the issue is https://github.com/joomla-framework/filesystem/blob/3.x-dev/src/File.php#L163 .
However, a few lines below we have another log which could need the same change: https://github.com/joomla-framework/filesystem/blob/3.x-dev/src/File.php#L173 .
The path to the Joomla root can be removed from the message in the same way as it can be seen here: https://github.com/joomla-framework/filesystem/pull/44/files#diff-b56e199bd976f7eaf5aa9fca93ebc32041da2f701956fc2f3c20cf3d06f81ce7 .
Does this print the full path on disk? if so we probably want to substitute it with JPATH_ROOT or something (even in the UI) for the shared hosting environments. We typically don't print out the details of the hosting path into the UI.