Feeling Lucky
RTC
PR-4.4-dev
[#42938] - [4.4] [BUGFIX] Enforce UTF-8 on CSS Files
- Fixed in Code Base
- 11 Mar 2024
- Medium
- Build: 4.4-dev
- # 42938
- Diff
- dgrammatiko:4.4-dev-fa-icons-utf
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #42611 .
Summary of Changes
Adds @charset "UTF-8"; as a first line on all the CSS files. Docs: https://developer.mozilla.org/en-US/docs/Web/CSS/@charset
Testing Instructions
Ensure your browser default encoding IS NOTUTF-8- Download and install Joomla from this Pull Request
- Check that icons don't get weird...
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
dgrammatiko
- comment
- 2 Mar 2024
How?
Turns out only safari allows changing the default encoding. FF and Chrome do not expose this setting anymore
Fedik
- comment
- 11 Mar 2024
I have tested this item ✅ successfully on ec1e092
with utf-8 better than without :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42938.
viocassel
- comment
- 11 Mar 2024
I have tested this item ✅ successfully on ec1e092
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42938.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-4.4-dev
|
||
Quy
- comment
- 11 Mar 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42938.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-11 16:30:01 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
RTC
|
||
laoneo
- comment
- 11 Mar 2024
Thanks!
How?