Feeling Lucky
Feature
Unit/System Tests
PR-5.1-dev
PR-5.2-dev
[#42939] - [5.2] Move the Cypress Tests to ESM
- Closed
- 17 May 2024
- Medium
- Build: 5.1-dev
- # 42939
- Diff
- dgrammatiko:5.1-dev-esm-tests
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Move to ESM (no
require()) - use
.mjsfor the esm modules
Testing Instructions
If tests pass, everything is ok. Just review the code
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
@richard67 could you bless the drone config?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests JavaScript |
| Labels |
Added:
Unit/System Tests
PR-5.1-dev
|
||
HLeithner
- comment
- 24 Apr 2024
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-17 08:01:07 |
| Closed_By | ⇒ | dgrammatiko | |
| Labels |
Added:
Feature
PR-5.2-dev
|
||
dgrammatiko
- comment
- 17 May 2024
I guess there's no interest for this
laoneo
- comment
- 17 May 2024
Please reopen, this is a great step forward. I will see what we can do here.
| Status | Closed | ⇒ | New |
| Closed_Date | 2024-05-17 08:01:07 | ⇒ | |
| Closed_By | dgrammatiko | ⇒ |
| Status | New | ⇒ | Pending |
laoneo
- comment
- 17 May 2024
Can you fix the conflicts, I can then sign drone.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-17 12:24:54 |
| Closed_By | ⇒ | dgrammatiko |
dgrammatiko
- comment
- 17 May 2024
Hmm, it seems I can't do that on GitHub so I guess I have to redo this
@laoneo would you like to merge this? in 5.1 or 5.2?