Composer Dependency Changed PHP 8.x PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
2 Mar 2024

Pull Request for Issues #39960 #42317 #42830 .

Summary of Changes

This pull request (PR) updates the composer dependency to our application framework from 3.0.0 to 3.0.1 in the 5.1-dev branch to get the fix from joomla-framework/application#121 for the error mentioned in the issues referenced above. The update contains only the fix from that PR, there are no other changes from 3.0.0 to 3.0.1, see joomla-framework/application@3.0.0...3.0.1 .

I've made this PR for 5.1-dev because there is not any 5.0.4 release planned.

The change from this PR here is also included in PR #42945 , so if that gets merged, this one here is obsolete.

The issues were also reported for 4.4.x, which currently uses version 2.0.4 of the application framework.

As soon as the PR in the framework repository joomla-framework/application#122 has been merged into the 2.0-dev branch and a new 2.* release has been created, I will make a PR here for the 4.4-dev branch to get that update.

Testing Instructions

It is not enough to apply the changes of this PR with patchtester. It needs to use an installation package created by drone for this PR to make a new installation, or the update package or custom update URL created by drone for updating to 5.0-dev + this PR. All of that can be found here https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/42937/downloads/74142/ .

Or if you have a development environment with composer and npm, apply the change from this PR and then run composer install.

Make sure that PHP errors are logged into a file by having log_errors = On and error_log pointing to a writable, existing file in PHP settings (php.ini).

Set error reporting to maximum in Global Configuration.

Create a GET Request scheduled task.

For the Request URL, specify the root of the installation.

Click Run Test button.

Check PHP error log.

Actual result BEFORE applying this Pull Request

stripos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /home/name/public_html/libraries/vendor/joomla/application/src/Web/WebClient.php on line XXX.

Expected result AFTER applying this Pull Request

No errors like the above mentioned.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 2 Mar 2024
avatar richard67 richard67 - change - 2 Mar 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2024
Category External Library Composer Change
avatar richard67 richard67 - change - 2 Mar 2024
Labels Added: Composer Dependency Changed PR-5.1-dev
avatar richard67 richard67 - change - 2 Mar 2024
Title
[5.1] Composer update joomla/application from 3.0.0 to 3.0.1 to fix PHP 8,1 deprecation
[5.1] Composer update joomla/application from 3.0.0 to 3.0.1 to fix PHP 8.1 deprecation
avatar richard67 richard67 - edited - 2 Mar 2024
avatar richard67 richard67 - change - 2 Mar 2024
The description was changed
avatar richard67 richard67 - edited - 2 Mar 2024
avatar richard67 richard67 - change - 2 Mar 2024
The description was changed
avatar richard67 richard67 - edited - 2 Mar 2024
avatar richard67 richard67 - change - 2 Mar 2024
The description was changed
avatar richard67 richard67 - edited - 2 Mar 2024
avatar richard67 richard67 - change - 2 Mar 2024
The description was changed
avatar richard67 richard67 - edited - 2 Mar 2024
avatar richard67 richard67 - change - 2 Mar 2024
The description was changed
avatar richard67 richard67 - edited - 2 Mar 2024
avatar richard67 richard67 - change - 2 Mar 2024
The description was changed
avatar richard67 richard67 - edited - 2 Mar 2024
avatar richard67 richard67 - change - 2 Mar 2024
The description was changed
avatar richard67 richard67 - edited - 2 Mar 2024
avatar Quy
Quy - comment - 2 Mar 2024

Will be added soon. Up to now I can't really reproduce the issue.

Create a GET Request scheduled task.
For the Request URL, specify the root of the installation.
Click Run Test button.
See PHP error log.

avatar alikon alikon - test_item - 3 Mar 2024 - Tested successfully
avatar alikon
alikon - comment - 3 Mar 2024

I have tested this item ✅ successfully on 74309a1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42937.

avatar richard67 richard67 - change - 3 Mar 2024
The description was changed
avatar richard67 richard67 - edited - 3 Mar 2024
avatar richard67
richard67 - comment - 3 Mar 2024

Will be added soon. Up to now I can't really reproduce the issue.

Create a GET Request scheduled task. For the Request URL, specify the root of the installation. Click Run Test button. See PHP error log.

@Quy Thanks. Instructions added.

avatar richard67 richard67 - change - 3 Mar 2024
The description was changed
avatar richard67 richard67 - edited - 3 Mar 2024
avatar richard67 richard67 - change - 3 Mar 2024
The description was changed
avatar richard67 richard67 - edited - 3 Mar 2024
avatar richard67 richard67 - change - 3 Mar 2024
The description was changed
avatar richard67 richard67 - edited - 3 Mar 2024
avatar laoneo laoneo - change - 4 Mar 2024
Labels Added: PHP 8.x
avatar laoneo laoneo - change - 4 Mar 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-03-04 13:23:11
Closed_By laoneo
avatar laoneo laoneo - close - 4 Mar 2024
avatar laoneo
laoneo - comment - 4 Mar 2024

Closing this one as the package was updated as part of #42945.

Add a Comment

Login with GitHub to post a comment