Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42895] - [4.x] Treeselect fixes

RTC NPM Resource Changed PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
26 Feb 2024

Pull Request for Issue #41309

Summary of Changes

  1. Fix the treeselect dropdowns not working
  2. Fix the check/uncheck buttons not toggling checkboxes that had been manually changed (backported from #42776)
  3. Fix select/deselect changing the state of the current menu (backported from #42776)

Testing Instructions

  1. Go to edit any module in the Module Manager
  2. Navigate to the Menu Assignment tab
  3. Change the assignment to "Only on selected pages"

Test 1:
Ensure the dropdown menu opens as shown below:
image

Test 2:

  1. Open the dropdown menu and click "select" or "unselect"
    All checkboxes (including the one parallel to the dropdown toggle) should be toggled

Test 3:

  1. Check (or uncheck) any checkbox
  2. Click the buttons shown above:
    image

All checkboxes should be toggled.

@LadySolveig @Quy

avatar C-Lodder C-Lodder - open - 26 Feb 2024
avatar C-Lodder C-Lodder - change - 26 Feb 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2024
Category ⇒ Repository NPM Change JavaScript
avatar Quy
Quy - comment - 26 Feb 2024

Can this be improved to not toggle disabled checkboxes?

42895-menu-assignment

avatar C-Lodder
C-Lodder - comment - 26 Feb 2024

@Quy - It wouldn't make the UX better to be honest. If a checkbox appears to be "disabled" (as shown in your screenshot), I'd assume I wouldn't be able to manually check it, which the user should be able to.

avatar Quy
Quy - comment - 26 Feb 2024

It is unchecked and not toggleble by default for URL, Alias, Heading, however, the All/None and Select/Deselect toggle them. Ideally, they should be skipped with these actions.

avatar C-Lodder
C-Lodder - comment - 26 Feb 2024

Oh I see. Didn't know that was the expected behavior. Will take a look tomorrow morning

avatar C-Lodder C-Lodder - change - 27 Feb 2024
Labels Added: NPM Resource Changed PR-4.4-dev
avatar C-Lodder
C-Lodder - comment - 27 Feb 2024

@Quy fixed

avatar fgsw fgsw - test_item - 27 Feb 2024 - Tested successfully
avatar fgsw
fgsw - comment - 27 Feb 2024

I have tested this item ✅ successfully on 1ce3ae6

Test by using prebuilt package:

image

PR having label NPM Resource Changed can't be tested by Patchtester.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42895.
avatar Quy Quy - test_item - 27 Feb 2024 - Tested successfully
avatar Quy
Quy - comment - 27 Feb 2024

I have tested this item ✅ successfully on 1ce3ae6

Thank you!!!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42895.

avatar Quy Quy - change - 27 Feb 2024
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 27 Feb 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42895.

avatar Quy Quy - change - 27 Feb 2024
Labels Added: RTC
avatar laoneo
laoneo - comment - 4 Mar 2024

@C-Lodder can you fix the whitespaces?

avatar C-Lodder C-Lodder - change - 4 Mar 2024
Labels Added: Updates Requested
avatar C-Lodder
C-Lodder - comment - 4 Mar 2024

@laoneo Done.
Silly windows eol

avatar laoneo
laoneo - comment - 4 Mar 2024

@C-Lodder thanks

avatar laoneo laoneo - change - 4 Mar 2024
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-03-04 15:47:30
Closed_By ⇒ laoneo
Labels Removed: Updates Requested
avatar laoneo laoneo - close - 4 Mar 2024
avatar laoneo laoneo - merge - 4 Mar 2024
avatar laoneo
laoneo - comment - 4 Mar 2024

Thanks!

Add a Comment

Login with GitHub to post a comment