[#42891] - [5.1] Complete com_search deprecation #40727
- Fixed in Code Base
- 10 Apr 2024
- Medium
- Build: 4.4-dev
- # 42891
- Diff
- brianteeman:search
User tests: Successful: Unsuccessful:
@hackware deprecated various search methods in libraries/src/Language/Language.php in #40727
This PR completes that PR by deprecating their use in the localise.php file
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
I have tested this item ✅ successfully on 51255d3
I looked at the code and read the comments so it looks OK to me as a bug fix for a previous commit.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42891.
@brianteeman then we have to change these depreciations you are talking about to 7.0 as well. Better to follow our deprecation policy and postpone already added deprecations than vice versa.
fine by me
@brianteeman can you rebase this one to 5.1-dev, so we can merge it.
| Labels |
Added:
Language Change
PR-4.4-dev
|
||
| Labels |
Added:
PR-5.1-dev
|
||
| Title |
|
||||||
I have tested this item ✅ successfully on f7ac86b
Doc blocks are correct
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42891.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42891.
| Labels |
Added:
RTC
Removed: PR-4.4-dev |
||
This is up to @bembelimen or @LadySolveig as they are the RM.
This is now also to late for 5.1, so it would have to go into 5.2-dev
I am not remaking it. Someone else can fix your mistake. The pr was made and tested in good time.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-10 22:58:36 |
| Closed_By | ⇒ | LadySolveig |
Thank you @brianteeman and for review @ceford and @laoneo
thanks - appreciate it
it's too late to deprecated anything in 4.4, that's only allowed in x.y.0 releases. In this case I would deprecate it with 5.1 and remove it with 7.0