Summary of Changes

If you have a script.php in your extension which extends the Installerscript but also implements the InstallerScriptInterface you get an Internal Server Error because the preflight in the Installerscript does not match the function declaration in the InstallerScriptInterface.

Testing Instructions

This is a little hard :)

1. Create a script.php to be used in an extension to be installed
2. The script.php needs to contain this code

<?php
use Joomla\CMS\Installer\InstallerAdapter;
use Joomla\CMS\Installer\InstallerScript;
use Joomla\CMS\Installer\InstallerScriptInterface;

defined('_JEXEC') or die;

return new class () implements ServiceProviderInterface {
    public function register(Container $container)
    {
        $container->set(
            InstallerScriptInterface::class,
            new class ()  extends InstallerScript implements InstallerScriptInterface {
                public function install(InstallerAdapter $adapter): bool
                {
                    return true;
                }

                public function update(InstallerAdapter $adapter): bool
                {
                    return true;
                }

                public function uninstall(InstallerAdapter $adapter): bool
                {
                    return true;
                }

                public function preflight(string $type, InstallerAdapter $adapter): bool
                {
                    return true;
                }
                public function postflight(string $type, InstallerAdapter $adapter): bool
                {
                    return true;
                }
            }
        );
    }
};

3. Add the script.php to your extension
4. Install the extension
5. Notice the Internal Server Error
6. Apply the patch
7. Install the extension
8. Notice the extension installs as expected

Actual result BEFORE applying this Pull Request

You get an Internal Server Error

Expected result AFTER applying this Pull Request

The extension is installed

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed