RTC NPM Resource Changed PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
29 Nov 2023

Pull Request for Issue # .

Summary of Changes

  • Localise my own gzip package @dgrammatiko/compress

Testing Instructions

Check out this PR

  • run npm i
  • run npm gzip

Check that the gzipped files inside the media folder are created
Rename the htaccess.txt and check if the gzipped files are loading correctly

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar dgrammatiko dgrammatiko - open - 29 Nov 2023
avatar dgrammatiko dgrammatiko - change - 29 Nov 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Nov 2023
Category JavaScript Repository NPM Change
avatar MacJoom MacJoom - alter_testresult - 5 Dec 2023 - MacJoom: Not tested
avatar MacJoom MacJoom - test_item - 5 Dec 2023 - Tested successfully
avatar MacJoom
MacJoom - comment - 5 Dec 2023

I have tested this item ✅ successfully on 918bb2c

Gzip files are created. Website loads OK. I had to run 'composer install' after checkout. Then 'npm ci', then 'npm run gzip' (not npm gzip). Turned on 'Gzip Page Compression' in Global Configuration, Server Tab. Check Requests to js or css in Browser debug page. Content-Encoding must be gzip.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42428.

avatar viocassel viocassel - test_item - 15 Jan 2024 - Tested successfully
avatar viocassel
viocassel - comment - 15 Jan 2024

I have tested this item ✅ successfully on 918bb2c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42428.

avatar richard67 richard67 - change - 16 Jan 2024
Status Pending Ready to Commit
Labels Added: NPM Resource Changed PR-5.0-dev
avatar richard67
richard67 - comment - 16 Jan 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42428.

avatar richard67
richard67 - comment - 16 Jan 2024

@bembelimen @HLeithner Is this PR ok for 5.0-dev? Or should it be rebased to 5.1-dev?

avatar HLeithner
HLeithner - comment - 17 Jan 2024

5.1 please

avatar Quy Quy - change - 17 Jan 2024
Labels Added: RTC PR-5.1-dev
Removed: PR-5.0-dev
avatar LadySolveig LadySolveig - close - 2 Mar 2024
avatar LadySolveig LadySolveig - merge - 2 Mar 2024
avatar LadySolveig LadySolveig - change - 2 Mar 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-03-02 16:44:00
Closed_By LadySolveig
avatar LadySolveig
LadySolveig - comment - 2 Mar 2024

Thank you @dgrammatiko and also for testing @MacJoom @viocassel

Add a Comment

Login with GitHub to post a comment