Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42427] - [5.x] Drop postcss, own package

RTC NPM Resource Changed PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
29 Nov 2023

Pull Request for Issue # .

Summary of Changes

  • Drop packages: postcss
  • Drop my own package postcss-url-version and replace it with an alter version of @dgrammatiko/lightningcss-url-version which does exactly the same versioning of the urls but based on LightningCSS

Testing Instructions

Needs CLI commands

Before applying this PR:

  • run npm i
  • run npm run cssversioning
  • Store the media folder somewhere in your HDD outside of the repo

Apply the PR

  • run npm i
  • run npm run cssversioning
  • compare the media folder with the one saved previously

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar dgrammatiko dgrammatiko - open - 29 Nov 2023
avatar dgrammatiko dgrammatiko - change - 29 Nov 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Nov 2023
Category ⇒ JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 29 Nov 2023
Labels Added: NPM Resource Changed PR-5.0-dev
avatar MacJoom MacJoom - test_item - 5 Dec 2023 - Tested successfully
avatar MacJoom
MacJoom - comment - 5 Dec 2023

I have tested this item ✅ successfully on 84796bb

Media folder identical - npm run cssversioning runs much faster

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42427.

avatar viocassel viocassel - test_item - 16 Jan 2024 - Tested successfully
avatar viocassel
viocassel - comment - 16 Jan 2024

I have tested this item ✅ successfully on 84796bb

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42427.

avatar alikon alikon - change - 16 Jan 2024
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 16 Jan 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42427.

avatar Quy Quy - change - 17 Jan 2024
Labels Added: RTC PR-5.1-dev
Removed: PR-5.0-dev
avatar LadySolveig LadySolveig - close - 2 Mar 2024
avatar LadySolveig LadySolveig - merge - 2 Mar 2024
avatar LadySolveig LadySolveig - change - 2 Mar 2024
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-03-02 16:40:40
Closed_By ⇒ LadySolveig
avatar LadySolveig
LadySolveig - comment - 2 Mar 2024

Thank you @dgrammatiko and also for testing @MacJoom @viocassel

Add a Comment

Login with GitHub to post a comment