RTC PHP 8.x bug PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
30 Nov 2023

Pull Request for Issue #41553 .

Summary of Changes

declared

Testing Instructions

with php 8.2
set error report to maximum
go to Joomla Updatde
and / or php cli/joomla.php core:check-updates

Actual result BEFORE applying this Pull Request

Deprecated Creation of dynamic property ....

Expected result AFTER applying this Pull Request

no more Deprecated

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 30 Nov 2023
avatar alikon alikon - change - 30 Nov 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Nov 2023
Category Libraries
avatar toivo toivo - test_item - 1 Dec 2023 - Tested unsuccessfully
avatar toivo
toivo - comment - 1 Dec 2023

I have tested this item ? unsuccessfully on 3d9d8f1

Tested in Joomla 5.0.1 using PHP 8.2.13 and 8.3.0 in Wampserver 3.3.2 and Windows 11.
The CLI test using PHP 8.2.11 succeeded.

The backend tests had only partial success: 'Check for Updates' and 'Upload & Update' work ok but 'Reinstall Joomla! core files' reports an error: "0 Cannot access protected property Joomla\CMS\Updater\Update::$sha256"

Call Stack

Function Location

1 () JROOT\administrator\components\com_joomlaupdate\src\Model\UpdateModel.php:473
2 Joomla\Component\Joomlaupdate\Administrator\Model\UpdateModel->isChecksumValid() JROOT\administrator\components\com_joomlaupdate\src\Model\UpdateModel.php:448
3 Joomla\Component\Joomlaupdate\Administrator\Model\UpdateModel->download() JROOT\administrator\components\com_joomlaupdate\src\Controller\UpdateController.php:59
4 Joomla\Component\Joomlaupdate\Administrator\Controller\UpdateController->download() JROOT\libraries\src\MVC\Controller\BaseController.php:730
5 Joomla\CMS\MVC\Controller\BaseController->execute() JROOT\libraries\src\Dispatcher\ComponentDispatcher.php:143
6 Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() JROOT\libraries\src\Component\ComponentHelper.php:361
7 Joomla\CMS\Component\ComponentHelper::renderComponent() JROOT\libraries\src\Application\AdministratorApplication.php:150
8 Joomla\CMS\Application\AdministratorApplication->dispatch() JROOT\libraries\src\Application\AdministratorApplication.php:195
9 Joomla\CMS\Application\AdministratorApplication->doExecute() JROOT\libraries\src\Application\CMSApplication.php:306
10 Joomla\CMS\Application\CMSApplication->execute() JROOT\administrator\includes\app.php:58
11 require_once() JROOT\administrator\index.php:32


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42429.
avatar alikon alikon - change - 1 Dec 2023
Labels Added: PHP 8.x bug PR-5.0-dev
avatar alikon
alikon - comment - 1 Dec 2023

when you have time, should be fixed the Reinstall Joomla

avatar toivo toivo - test_item - 2 Dec 2023 - Tested successfully
avatar toivo
toivo - comment - 2 Dec 2023

I have tested this item ✅ successfully on 4608c4a

Tested successfully in Joomla 5.0.1 on Wampserver 3.3.2 using PHP 8.3.0. All options in Joomla Update worked all right in Joomla 5.0.1.

Noticed possible regression: after I updated the test site to 5.0.2-dev from 2 December, the option to reinstall Joomla core files was not presented at all.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42429.

avatar hans2103 hans2103 - test_item - 15 Dec 2023 - Tested successfully
avatar hans2103
hans2103 - comment - 15 Dec 2023

I have tested this item ✅ successfully on 4608c4a

With the changes applied I do not have the mentioned issue anymore


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42429.

avatar alikon alikon - change - 15 Dec 2023
Status Pending Ready to Commit
avatar alikon
alikon - comment - 15 Dec 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42429.

avatar alikon alikon - edited - 15 Dec 2023
avatar bembelimen bembelimen - change - 16 Dec 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-12-16 06:36:38
Closed_By bembelimen
Labels Added: RTC
avatar bembelimen bembelimen - close - 16 Dec 2023
avatar bembelimen bembelimen - merge - 16 Dec 2023
avatar bembelimen
bembelimen - comment - 16 Dec 2023

Thx

avatar ChristineWk
ChristineWk - comment - 16 Jan 2024

A user from german forum reports: When attempting to update from Joomla 5.0.1 to Joomla 5.0.2, the user receives the following error message:
cannot access protected property Joomla\CMS\Updater\Update::$sha256

Call stack is identical to above. Checked with PHP 8.2. also with PHP 8.1

I looked at these lines in a fresh J 5.0.2. I think, there it would be lines 248-250

@alikon can you please investigate? Thanks

avatar alikon
alikon - comment - 16 Jan 2024

this pr has been merged in 5.0.2 so it is not present in 5.0.1

avatar ChristineWk
ChristineWk - comment - 16 Jan 2024

this pr has been merged in 5.0.2 so it is not present in 5.0.1

Yes, pr has been merged in 5.0.2, How to solve this now - what actions are required now?
Thank you.

avatar alikon
alikon - comment - 16 Jan 2024

you can apply this change to your 5.0.1

avatar ChristineWk
ChristineWk - comment - 16 Jan 2024

ah, I partially understand.
I think user has already updated from 5.0.1 to 5.0.2.
Because the message just appeared after the update.
If I see it correctly, the changes are in 5.0.2, but of course other lines now - but therefore have no effect - after Update from 5.0.1?

avatar ChristineWk
ChristineWk - comment - 16 Jan 2024

you can apply this change to your 5.0.1

I will inform user about. Thank you.

Add a Comment

Login with GitHub to post a comment