@wilsonge Does J4's CSS support IE11 out of the box?

If so, I'll need to make a slight change

BS5 dropped IE11 support so as far as I’m aware the css doesn’t in the core templates. Honestly I don’t remember anymore what we did for the system stuff. Based on https://github.com/joomla/joomla-cms/blob/4.4-dev/package.json#L36 I guess we did try for it? But I’m definitely not sure

4 does not support IE 11 anymore, so you are free to change.

@laoneo Thanks for clarifying. No more changes require on my part then.
Ready for review/testing.

Merging it as system tests are not failing and npm went trough fine.

Thanks!

Last night the nightly builds for 4.4-dev failed, while the others succeeded. Trying locally on an Ubuntu shows that the first build succeeded, but then running again a build fails with:

> joomla@4.4.1 versioning
> node build/build.js --versioning

[Error: ENOENT: no such file or directory, lstat '/drone/src/build/tmp/1699693449/media/com_media/js/media-manager-es5.min.js'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'lstat',
  path: '/drone/src/build/tmp/1699693449/media/com_media/js/media-manager-es5.min.js'
}
`npm run versioning` did not complete as expected.

The same error is also shown in the log of a build by Drone (not in the builds for PRs, those do not run that nightly_build task).

@C-Lodder Possibly related to this PR? @dgrammatiko Maybe you have an idea what goes wrong?

When running npm run versioning like the build.php script does, I get:

$ npm run versioning

> joomla@4.4.1 versioning
> node build/build.js --versioning

node:internal/modules/cjs/loader:1051
  throw err;
  ^

Error: Cannot find module 'commander'
Require stack:
- /home/richard/lamp/public_html/joomla-cms-4.4-dev/build/build.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1048:15)
    at Module._load (node:internal/modules/cjs/loader:901:27)
    at Module.require (node:internal/modules/cjs/loader:1115:19)
    at require (node:internal/modules/helpers:130:18)
    at Object.<anonymous> (/home/richard/lamp/public_html/joomla-cms-4.4-dev/build/build.js:19:21)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/richard/lamp/public_html/joomla-cms-4.4-dev/build/build.js'
  ]
}

Node.js v20.6.1
$

@richard67 I will publish a lightningCSS version of the PostCSS plugin (hopefully I could code it today on my way to Frankfurt)...

Error: Cannot find module 'commander'

Hmm, that's a different problem... I'll have a look

@dgrammatiko It fails here: https://github.com/joomla/joomla-cms/blob/4.4-dev/build/build.js#L19

Possibly something wrong with package-lock.json?

@richard67 can you allow the drone changes on #42331 ? (someone needs to sign that pr)

See also joomla-projects/docker-images#72 .

PR #42331 seems to fix the issue with the versioning JS which I could reproduce on my local Ubuntu. For the nightly builds it will also need joomla-projects/docker-images#72 .

@richard67 media-manager-es5.min.js doesn't seem to be created. I'll look into it.

Seems to be caused by this: https://github.com/joomla/joomla-cms/blob/4.4-dev/build/build.js#L173

When running npm run build:com_media, the media-manager-es5.js and media-manager-es5.min.js files are created (as expected).
When running npm i, the files aren't created due to process.exit(0);.

@dgrammatiko Perhaps some of the promises aren't being handled correctly?

@C-Lodder you can replace the promise.all with regular thens, but the problem was the resolution of the commander module. The latest 4.4.0 branch should work without any problems, after #42331

@dgrammatiko @C-Lodder it something to do with this

media-manager-es5.min.js file is removed by this code.

It seems NODE_ENV=PRODUCTION is ignored after recent changes.

In set NODE_ENV=PRODUCTION && node build/build.js --com-media command

process.env.NODE_ENV is undefined.

@C-Lodder @Fedik I have no clue why this fails for you. All commands work perfectly on my side:
npm i:

npm run build:com_media

Did you remove the node_modules folder before trying npm i?

@Fedik #42340 should fix the env variables for Node 20

@dgrammatiko running npm run build:com_media has always worked. However when running npm i (which not only fetches the dependencies, but also runs all build tasks), it doesn't generate the media-manager-es5.min.js || media-manager-es5.js files.

The underlying reason is https://github.com/joomla/joomla-cms/blob/4.4-dev/build/build.js#L173

I don't actually know why the process is being manually terminated to be honest. Node.js will automatically terminates when all async tasks have completed.
Running it manually will terminate everything, even if there are still pending async tasks....which clearly seem to be the case here.
The media manager babel/rollup stuff is being killed before it's complete.

I'd strongly suggest removing the line above and letting it finish gracefully.

#42341

@C-Lodder probably is a windows thing, Linux and macOS are fine

Not windows, Linux.
But it actualy works for me now