NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
9 Nov 2023

Summary of Changes

Replace Terser and PostCSS with ESBuild (Go) and LightningCSS (Rust) to improve build times.

Testing Instructions

  1. Run npm i
  2. Perform a sanity test to ensure there and no JS errors or styling issues

BEFORE (local machine)

Timer: Build finished in 35396 ms

AFTER (local machine)

Timer: Build finished in 17231 ms

@dgrammatiko I haven't removed PostCSS completely because the build scripts are still using your custom PostCSS plugin, which I didn't want to touch.

avatar C-Lodder C-Lodder - open - 9 Nov 2023
avatar C-Lodder C-Lodder - change - 9 Nov 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2023
Category JavaScript Repository NPM Change
avatar C-Lodder C-Lodder - change - 9 Nov 2023
Labels Added: NPM Resource Changed PR-5.0-dev
avatar C-Lodder C-Lodder - change - 9 Nov 2023
The description was changed
avatar C-Lodder C-Lodder - edited - 9 Nov 2023
avatar C-Lodder C-Lodder - change - 9 Nov 2023
The description was changed
avatar C-Lodder C-Lodder - edited - 9 Nov 2023
avatar dgrammatiko
dgrammatiko - comment - 9 Nov 2023

I haven't removed PostCSS completely because the build scripts are still using your custom PostCSS plugin, which I didn't want to touch.

I could do a lightningCSS plugin for the versioning of the URLs

avatar laoneo
laoneo - comment - 9 Nov 2023

Great PR! Would you mind to move this to 4.4? As 4 is still around for 2 years, it would help maintaining it.

avatar C-Lodder
C-Lodder - comment - 9 Nov 2023

@laoneo sure, will redo on 4.4

avatar C-Lodder C-Lodder - change - 9 Nov 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-11-09 11:50:15
Closed_By C-Lodder
avatar C-Lodder
C-Lodder - comment - 9 Nov 2023

Closing for #42325

avatar C-Lodder C-Lodder - close - 9 Nov 2023

Add a Comment

Login with GitHub to post a comment