? NPM Resource Changed bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
9 Nov 2023

Pull Request for Issue # .

Summary of Changes

Fix field Color (Simple) rendering. rendering of the close button.

Testing Instructions

Run npm install
Add Color field somewhere, example in mod_custome XML, or in template XML.

<field type="color" name="color" label="Color" control="simple"/>

Actual result BEFORE applying this Pull Request

Close button looks bad
Screenshot 2023-11-09_11-58-15

Expected result AFTER applying this Pull Request

Close button looks good
Screenshot 2023-11-09_12-01-20

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 9 Nov 2023
avatar Fedik Fedik - change - 9 Nov 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2023
Category JavaScript Repository NPM Change
avatar Quy Quy - test_item - 9 Nov 2023 - Tested successfully
avatar Quy
Quy - comment - 9 Nov 2023

I have tested this item ✅ successfully on a21b889


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42323.

avatar viocassel viocassel - test_item - 10 Nov 2023 - Tested successfully
avatar viocassel
viocassel - comment - 10 Nov 2023

I have tested this item ✅ successfully on a21b889


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42323.

avatar alikon alikon - change - 10 Nov 2023
Status Pending Ready to Commit
avatar alikon
alikon - comment - 10 Nov 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42323.

avatar MacJoom MacJoom - close - 10 Nov 2023
avatar MacJoom MacJoom - merge - 10 Nov 2023
avatar MacJoom MacJoom - change - 10 Nov 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-11-10 10:16:43
Closed_By MacJoom
Labels Added: ? NPM Resource Changed bug PR-4.4-dev
avatar MacJoom
MacJoom - comment - 10 Nov 2023

Thank you!

Add a Comment

Login with GitHub to post a comment